From: drkm <darkman_spam@yahoo.fr>
Subject: Re: bad fixes to a higher level problem
Date: Thu, 30 Dec 2004 22:43:12 +0100 [thread overview]
Message-ID: <wky8ffsbrj.fsf@yahoo.fr> (raw)
In-Reply-To: <sdd5wrikpt.fsf@wes.hardakers.net>
Wes Hardaker <wes@hardakers.net> writes:
> @@ -10740,12 +10741,14 @@
> "Go to the same level (or less) next thread.
> If PREVIOUS is non-nil, go to previous thread instead.
> Return the article number moved to, or nil if moving was impossible."
> - (let ((level (gnus-summary-thread-level))
> + (let ((level (or (gnus-summary-thread-level) 0))
> (way (if previous -1 1))
> - (beg (point)))
> + (beg (point))
> + thlevel)
> (forward-line way)
> (while (and (not (eobp))
> - (< level (gnus-summary-thread-level)))
> + (setq thlevel (gnus-summary-thread-level))
> + (< level thlevel))
> (forward-line way))
> (if (eobp)
> (progn
Why introduce `thlevel' if you don't use it ? Are there other
reference to this variable, not shown in the patch ?
--drkm
next prev parent reply other threads:[~2004-12-30 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 20:39 Wes Hardaker
2004-12-30 21:43 ` drkm [this message]
2004-12-31 6:11 ` Wes Hardaker
2004-12-31 6:33 ` drkm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wky8ffsbrj.fsf@yahoo.fr \
--to=darkman_spam@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).