small bug when logging into an NNTP server

small bug when logging into an NNTP server

[Scott Hofmann]

After upgrading to pgnus-0.75, I got an error just before it asked me for my
username and password to log into my nntp server. I traced the problem down to
nntp.el: it was still using the obsoleted nnmail-read-passwd function. I
replaced that with mail-source-read-passwd and everything now works:

1999-02-02 10:55:23  Scott Hofmann  <shofmann@mindspring.com>

	* nntp.el: Use mail-source-read-passwd instead of nnmail-read-passwd.

*** nntp.el.orig	Tue Feb  2 10:59:53 1999
--- nntp.el	Tue Feb  2 10:59:52 1999
***************
*** 221,227 ****
  (defvar nntp-async-process-list nil)
  
  (eval-and-compile
!   (autoload 'nnmail-read-passwd "nnmail")
    (autoload 'open-ssl-stream "ssl"))
  
  \f
--- 221,227 ----
  (defvar nntp-async-process-list nil)
  
  (eval-and-compile
!   (autoload 'mail-source-read-passwd "mail-source")
    (autoload 'open-ssl-stream "ssl"))
  
  \f
***************
*** 779,785 ****
         (or passwd
  	   nntp-authinfo-password
  	   (setq nntp-authinfo-password
! 		     (nnmail-read-passwd (format "NNTP (%s@%s) password: "
  						 user nntp-address))))))))))
  
  (defun nntp-send-nosy-authinfo ()
--- 779,785 ----
         (or passwd
  	   nntp-authinfo-password
  	   (setq nntp-authinfo-password
! 		     (mail-source-read-passwd (format "NNTP (%s@%s) password: "
  						 user nntp-address))))))))))
  
  (defun nntp-send-nosy-authinfo ()
***************
*** 789,795 ****
        (nntp-send-command "^3.*\r?\n" "AUTHINFO USER" user)
        (when t				;???Should check if AUTHINFO succeeded
  	(nntp-send-command "^2.*\r?\n" "AUTHINFO PASS"
! 			   (nnmail-read-passwd "NNTP (%s@%s) password: "
  					       user nntp-address))))))
  
  (defun nntp-send-authinfo-from-file ()
--- 789,795 ----
        (nntp-send-command "^3.*\r?\n" "AUTHINFO USER" user)
        (when t				;???Should check if AUTHINFO succeeded
  	(nntp-send-command "^2.*\r?\n" "AUTHINFO PASS"
! 			   (mail-source-read-passwd "NNTP (%s@%s) password: "
  					       user nntp-address))))))
  
  (defun nntp-send-authinfo-from-file ()
***************
*** 1254,1260 ****
  	 proc (concat
  	       (or nntp-telnet-passwd
  		   (setq nntp-telnet-passwd
! 			 (nnmail-read-passwd "Password: ")))
  	       "\n"))
  	(erase-buffer)
  	(nntp-wait-for-string nntp-telnet-shell-prompt)
--- 1254,1260 ----
  	 proc (concat
  	       (or nntp-telnet-passwd
  		   (setq nntp-telnet-passwd
! 			 (mail-source-read-passwd "Password: ")))
  	       "\n"))
  	(erase-buffer)
  	(nntp-wait-for-string nntp-telnet-shell-prompt)

--
J. Scott Hofmann                            Software Engineer
shofmann at mindspring dot com              Interactive Television Company
http://www.seas.gwu.edu/student/shofmann/   (703) 525-5625 x28