Gnus development mailing list
 help / color / mirror / Atom feed
From: Knut Anders Hatlen <kahatlen@gmail.com>
To: ding@gnus.org
Subject: Re: Missing marks with nnimap
Date: Sat, 30 Oct 2010 11:55:59 +0200	[thread overview]
Message-ID: <x6eib8dmxc.fsf@gmail.com> (raw)
In-Reply-To: <x6iq0kdq6w.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>>
>>> *nnimap <server> *nntpd** says this after M-g:
>>
>> [...]
>>
>>> * OK [PERMANENTFLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)] Permanent flags^M
>>
>> [...]
>>
>>> * 202 FETCH (FLAGS (%Flagged) UID 1215)^M
>>
>> Looks OK.  What does `G E' on the group after this look like?
>
> ("mail.autoderby" 3
>  ((1 . 1222))
>  ((seen (1223 . 1224)))
>  nil
>  ((modseq)
>   (uidvalidity . "6567453")
>   (active 1012 . 1224)
>   (permanent-flags %Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)))

Found it. The server doesn't have \* in PERMANENTFLAGS. And the
non-QRESYNC code in nnimap-update-info fails to see that \Flagged is
supported because it checks whether (%Flagged 1012 1027 ...)  is member
of permanent-flags. So it seems it's just missing a call to car before
calling memq. The attached patch made the problem go away for me.

-- 
Knut Anders

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: flags.diff --]
[-- Type: text/x-patch, Size: 510 bytes --]

diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index 8ea5063..7568807 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -1181,7 +1181,8 @@ textual parts.")
 	      (setq marks (gnus-info-marks info))
 	      (dolist (type (cdr nnimap-mark-alist))
 		(when (or (not (listp permanent-flags))
-			  (memq (assoc (caddr type) flags) permanent-flags)
+			  (memq (car (assoc (caddr type) flags))
+				permanent-flags)
 			  (memq '%* permanent-flags))
 		  (let ((old-marks (assoc (car type) marks))
 			(new-marks

  reply	other threads:[~2010-10-30  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 11:29 Knut Anders Hatlen
2010-10-29 23:35 ` Lars Magne Ingebrigtsen
2010-10-30  8:45   ` Knut Anders Hatlen
2010-10-30  9:55     ` Knut Anders Hatlen [this message]
2010-10-30 11:16       ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x6eib8dmxc.fsf@gmail.com \
    --to=kahatlen@gmail.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).