Gnus development mailing list
 help / color / mirror / Atom feed
From: Knut Anders Hatlen <kahatlen@gmail.com>
To: ding@gnus.org
Subject: Re: Backtrace from gnus-html-display-image
Date: Sun, 26 Sep 2010 18:32:24 +0200	[thread overview]
Message-ID: <x6eicgxy7b.fsf@gmail.com> (raw)
In-Reply-To: <x6iq1sxyrc.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Hi,
>
> When I try to show remote images in an article using W D W, I get this
> backtrace:
>
> Debugger entered--Lisp error: (wrong-number-of-arguments #[(url start end alt-text)

Hmm... Not a good idea to include those control characters in the
backtrace, it seems. Don't know if the entire message made it to the
mailing list. It was truncated in Gmane at least.

Anyways, what I was trying to say, was that the attached patch makes
displaying remote images work again by removing some unused parameters
from the function's signature.

-- 
Knut Anders

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: images.diff --]
[-- Type: text/x-patch, Size: 836 bytes --]

diff --git a/lisp/gnus-html.el b/lisp/gnus-html.el
index cb5d3c6..cc3c871 100644
--- a/lisp/gnus-html.el
+++ b/lisp/gnus-html.el
@@ -245,10 +245,10 @@ CHARS is a regexp-like character alternative (e.g., \"[)$]\")."
                                (> height 4))
                            (or (null width)
                                (> width 4)))
-                  (gnus-html-display-image url start end alt-text))))))))))
+                  (gnus-html-display-image url alt-text))))))))))
 
-(defun gnus-html-display-image (url start end alt-text)
-  "Display image at URL on text from START to END.
+(defun gnus-html-display-image (url alt-text)
+  "Display image at URL.
 Use ALT-TEXT for the image string."
   (if (gnus-html-cache-expired url gnus-html-image-cache-ttl)
       ;; We don't have it, so schedule it for fetching

  reply	other threads:[~2010-09-26 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26 16:20 Knut Anders Hatlen
2010-09-26 16:32 ` Knut Anders Hatlen [this message]
2010-09-26 16:34   ` Lars Magne Ingebrigtsen
2010-09-26 16:41     ` Knut Anders Hatlen
2010-09-26 16:34 ` Julien Danjou
2010-09-26 16:39   ` Julien Danjou
2010-09-26 16:46     ` Knut Anders Hatlen
2010-09-26 17:05       ` Julien Danjou
2010-09-26 17:09         ` Lars Magne Ingebrigtsen
2010-09-26 17:34           ` Julien Danjou
2010-09-26 17:38             ` Lars Magne Ingebrigtsen
2010-09-26 18:19               ` Julien Danjou
2010-09-26 17:15         ` Knut Anders Hatlen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x6eicgxy7b.fsf@gmail.com \
    --to=kahatlen@gmail.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).