Gnus v5.2.3 is released

Gnus v5.2.3 is released

[Lars Magne Ingebrigtsen]

Bug fixes.

Get it from <URL:http://www.ifi.uio.no/~larsi/gnus.tar.gz> or 
"ftp.ifi.uio.no:/pub/emacs/gnus/".

ChangeLog since last release:

Thu May 30 05:04:07 1996  Lars Magne Ingebrigtsen  <larsi@aegir.ifi.uio.no>

	* gnus.el (gnus-article-hide-headers): Show boring headers as
	well. 

Tue May 28 15:47:15 1996  Per Abrahamsen  <abraham@dina.kvl.dk>

	* custom.el ((fboundp 'event-point)): Wrong test.

Thu May 30 03:19:21 1996  Lars Magne Ingebrigtsen  <larsi@aegir.ifi.uio.no>

	* gnus.el (gnus-headers-decode-quoted-printable): Wrong name.

	* message.el (message-header-hook): Defvarred.

	* gnus-nocem.el (gnus-nocem-verifyer): Couldn't verify that it
	works. 

Thu May 30 00:25:46 1996  Lars Magne Ingebrigtsen  <larsi@ylfing.ifi.uio.no>

	* gnus-nocem.el (gnus-nocem-verify-issuer): Widen before
	verifying. 

Wed May 29 23:19:46 1996  Lars Magne Ingebrigtsen  <lars@eyesore.no>

	* custom.el (custom-xmas-set-text-properties): Changed name.

Wed May 29 23:01:52 1996  Paul D. Smith  <psmith@baynetworks.com>

	* gnus-cus.el: toggle -> sexp.

Wed May 29 23:00:48 1996  Lars Magne Ingebrigtsen  <lars@eyesore.no>

	* gnus-msg.el (gnus-inews-add-send-actions): Use `gnus-add-hook'. 

Wed May 29 22:52:47 1996  Francois Felix Ingrand  <felix@laas.fr>

	* gnus-topic.el (gnus-topic-remove-group): Would not delete groups
	from topics.

Wed May 29 08:57:20 1996  Lars Magne Ingebrigtsen  <lars@eyesore.no>

	* custom.el (custom-face-lookup): Avoid `modify-face' to speed up
	face retrieval on Indys & over slow modem lines.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen

Re: Gnus v5.2.3 is released

[Steven L Baur]

Compiling /usr/lib/xemacs/gnus-5.2.3/lisp/gnus-cache.el...
Loading gnus...
Loading mail-utils...
Loading timezone...
Loading nnheader...
Loading sendmail...
Loading nnheader-es...
Loading message...
Loading mailheader...
Loading easymenu...
Loading mail-abbrevs...
Loading message-xms...
Loading nnmail...
Loading gnus-cus...
Loading custom...
Loading /home/steve/.custom.el...
While compiling toplevel forms in file /usr/lib/xemacs/gnus-5.2.3/lisp/gnus-cache.el:
  !! Symbol's function definition is void ((set-face-stipple))

-- 
steve@miranova.com baur
GNU Emacs 19.31.2 (i486-unknown-linux, X toolkit) of Tue May 28 1996 on deanna.miranova.com

Re: Gnus v5.2.3 is released

[Per Abrahamsen]

You can make Gnus 5.2.3 compile under Emacs 19.31 with the following
commands:  

	cd gnus-5.2.3
	rm list/custom.el
	make

Re: Gnus v5.2.3 is released

[Steven L Baur]

I hadn't tried it under 19.31 yet.  Here are the patches for XEmacs:
(NOTE:  If you are using 19.14 and tm, you will have to patch the
custom.el in lisp/gnus as well, I don't know why).
===================================================================
RCS file: RCS/ChangeLog,v
retrieving revision 1.3
diff -u -r1.3 ChangeLog
--- ChangeLog	1996/05/30 06:54:24	1.3
+++ ChangeLog	1996/05/30 16:34:19
@@ -1,3 +1,8 @@
+Thu May 30 09:33:15 1996  Steven L Baur  <steve@miranova.com>
+
+	* custom.el ((and (fboundp 'modify-face) (not (featurep 'face-lock)))): 
+	Protect all calls to set-face-stipple with fboundp.
+
 Thu May 30 05:04:07 1996  Lars Magne Ingebrigtsen  <larsi@aegir.ifi.uio.no>
 
 	* gnus.el (gnus-article-hide-headers): Show boring headers as

===================================================================
RCS file: RCS/custom.el,v
retrieving revision 1.3
diff -u -r1.3 custom.el
--- custom.el	1996/05/30 06:54:24	1.3
+++ custom.el	1996/05/30 16:14:43
@@ -275,7 +275,8 @@
 	   bold-p italic-p underline-p)))
   (condition-case nil (set-face-foreground face foreground) (error nil))
   (condition-case nil (set-face-background face background) (error nil))
-  (condition-case nil (set-face-stipple face stipple) (error nil))
+  (if (fboundp 'set-face-stipple)
+      (condition-case nil (set-face-stipple face stipple) (error nil)))
   (if (string-match "XEmacs" emacs-version)
       (progn
 	(funcall (if bold-p 'make-face-bold 'make-face-unbold) face)
@@ -1545,7 +1546,8 @@
       (when (and bg
 		 (not (string-equal fg "default")))
 	(set-face-background name bg))
-      (when (and stipple
+      (when (and (fboundp 'set-face-stipple)
+		 stipple
 		 (not (eq stipple 'as-is)))
 	(set-face-stipple name))
       (when (and bold

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.

Re: Gnus v5.2.3 is released

[Steven L Baur]

The .custom.el written by XEmacs appears to be incompatible with GNU
Emacs 19.31.  Prior to attempting byte compilation with 19.31 I had
been experimenting with it on XEmacs, and had a new .custom.el created.

$ make
rm -f *.elc ; emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-compile
Wrote /usr/local/share/emacs/site-lisp/gnus-5.2/lisp/browse-url.elc
Wrote /usr/local/share/emacs/site-lisp/gnus-5.2/lisp/custom.elc
Wrote /usr/local/share/emacs/site-lisp/gnus-5.2/lisp/dgnushack.elc
Loading /home/steve/.custom.el...
While compiling toplevel forms in file /usr/local/share/emacs/site-lisp/gnus-5.2/lisp/gnus-cache.el:
  !! Wrong number of arguments ((#[(face pixmap &optional frame) "À     Â
%‡" [internal-set-face-1 face background-pixmap pixmap 6 frame] 6 289395 (internal-face-interactive "stipple")] 1))

I still don't think it's a good idea for Gnus to be loading a
.custom.el from the account doing the byte compiling.
--
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.

Re: Gnus v5.2.3 is released

[Per Abrahamsen]

>>>>> "SLB" == Steven L Baur <steve@miranova.com> writes:

SLB> The .custom.el written by XEmacs appears to be incompatible with GNU
SLB> Emacs 19.31.  

No.  The Gnus 5.2 custom.el is just broken.  It cannot read anything.
If you use the custom.el bundled with Emacs 19.31, you will probably
find that it can read your the XEmacs generated ".custom.el" file with
no problems.

Re: Gnus v5.2.3 is released

[Lars Magne Ingebrigtsen]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> No.  The Gnus 5.2 custom.el is just broken.  It cannot read anything.
> If you use the custom.el bundled with Emacs 19.31, you will probably
> find that it can read your the XEmacs generated ".custom.el" file with
> no problems.

The Gnus 5.2.3 custom.el is the one from 19.31 including your patches
and a rewrite of `custom-set-face' to make it not freeze the X server
on SGI Indys and some additional face dances to make it work under
XEmacs 19.14.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen

Re: Gnus v5.2.3 is released

[Lars Magne Ingebrigtsen]

Steven L Baur <steve@miranova.com> writes:

> I still don't think it's a good idea for Gnus to be loading a
> .custom.el from the account doing the byte compiling.

No, but how do you avoid that?  My mind is momentarily blank.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen

Re: Gnus v5.2.3 is released

[Steven L Baur]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@ifi.uio.no> writes:

Lars> Steven L Baur <steve@miranova.com> writes:
>> I still don't think it's a good idea for Gnus to be loading a
>> .custom.el from the account doing the byte compiling.

Lars> No, but how do you avoid that?  My mind is momentarily blank.

There exists eval-when-compile to only eval something when in the
bytecompiler.  Can't you do something similar with eval-when for when
*not* bytecompiling?

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.

Re: Gnus v5.2.3 is released

[Lars Magne Ingebrigtsen]

Steven L Baur <steve@miranova.com> writes:

> There exists eval-when-compile to only eval something when in the
> bytecompiler.  Can't you do something similar with eval-when for when
> *not* bytecompiling?

I tried an `(eval-when 'load)', but since the other files requires
custom, it's evaled when the other files are compiled instead.
*Sigh*. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen

Re: Gnus v5.2.3 is released

[Scott Blachowicz]

Steven L Baur <steve@miranova.com> wrote:

> There exists eval-when-compile to only eval something when in the
> bytecompiler.  Can't you do something similar with eval-when for when
> *not* bytecompiling?

How about something like this...
[not knowing the details, I'll invent some :-)]

	(eval-when-compile (setq no-dot-custom t))
	(defvar no-dot-custom nil)
	(or no-dot-custom (load-dot-custom))

Scott Blachowicz  Ph: 206/283-8802x240   Mathsoft (Data Analysis Products Div)
                                         1700 Westlake Ave N #500
scott@statsci.com                        Seattle, WA USA   98109
Scott.Blachowicz@seaslug.org

Re: Gnus v5.2.3 is released

[Per Abrahamsen]

Putting a 

	(setq custom-file "/dev/null")

in dgnushack.el should do the trick.

Re: Gnus v5.2.3 is released

[Lars Magne Ingebrigtsen]

Scott Blachowicz <scott@statsci.com> writes:

> How about something like this...
> [not knowing the details, I'll invent some :-)]
> 
> 	(eval-when-compile (setq no-dot-custom t))
> 	(defvar no-dot-custom nil)
> 	(or no-dot-custom (load-dot-custom))

This has the same problems as `(eval-when 'load)' -- custom.el is
required by the other files when byte-compiling, so the
`eval-when-compile' thing will fail (I think) when its being
compiled. 

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> Putting a 
> 
> 	(setq custom-file "/dev/null")
> 
> in dgnushack.el should do the trick.

So I've gone with this one instead.

-- 
  "Yes.  The journey through the human heart 
     would have to wait until some other time."