Re: Customizable tool bars

[Michael Piotrowski <mxp@dynalabs.de>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Thu, Mar 02 2006, Michael Piotrowski wrote:
>
>> The most important point for me is that a customize option which
>> apparently doesn't even apply to XEmacs shouldn't break Gnus on
>> XEmacs.
>
> I already wrote earlier that I'll fix this ASAP.  If you can't live
> with occasional breakage (especially on XEmacs which is not used by
> most Gnus developers), you should better not use the CVS version of
> Gnus for your daily work.  I don't have the resources to test every
> Gnus change on XEmacs (and each and every MULE/no-MULE/--with-whatever
> variant) myself.

I didn't mean to criticize you and I'm sorry if it sounded like I
would.  I'm fully aware that CVS Gnus might be borken sometimes.

I was actually referring to Katsumi Yamaoka's comment ("I also am not
sure whether counting colors is proper way, so I refrain from
installing it for the moment.").  In fact I intended to say two
things:

1. Even if counting color cells may not be the right way, it may be
   good to fix portability problems early.

2. If the whole setting only applies to GNU Emacs, conditionally using
   `device-color-cells' instead of `display-color-cells' doesn't
   really make sense, and maybe the whole defcustom should not be
   evaluated on XEmacs.  A crude implementation could be something
   like this:

   (if (not (featurep 'xemacs)) ; This setting doesn't apply to XEmacs
       (defcustom gmm-tool-bar-style (if (> (display-color-cells) 256)
                                         'gnome
                                       'retro)
         "Prefered tool bar style."
         :type '(choice (const :tag "GNOME style" 'gnome)
                        (const :tag "Retro look"  'retro))
         :group 'gmm))

   But I'm not sure how much of Gmm is GNU Emacs-specific, so a good
   solution may look different.

I admit I should have written this in the first place ;-)

Greetings

-- 
Michael Piotrowski, M.A.                               <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt>