Not enough arguments for format string

Not enough arguments for format string

[Frank Schmitt]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 5898 bytes --]

Hey,

I just did a git pull and starting gnus resulted in an error while
trying to open the IMAP server:

Opening TLS connection to `ltw.loris.tv'...
Opening TLS connection with `gnutls-cli -p imaps ltw.loris.tv'...failed
Opening TLS connection with `gnutls-cli -p imaps ltw.loris.tv
--protocols ssl3'...failed 
Opening TLS connection with `openssl s_client -connect
ltw.loris.tv:imaps -no_ssl2 -ign_eof'...done
Opening TLS connection to `ltw.loris.tv'...done
Entering debugger...

Debugger entered--Lisp error: (error "Not enough arguments for format string")
  message("Unable to open server nnimap+ltw due to: Wrong number of arguments: #[(mode host protocol) \"\\306\\307\\310\b	\n%\\210\b<\\211^[\\203\x13\0\b\\202\x15\0\bC\x18\\311\\312\b	\n$\x1c\\313\f\r\\\"\\211\x1e\x11\\203A\0\\306\\307\\314\b\\315\b\\235\\2035\0\\316\\2027\0\x0e\x11	\n&\x06\\210\x0e\x11\\202D\0\\317\\320\\215,\\207\" [mode host protocol listy cname auth-source-cache gnus-message 9 \"auth-source-user-or-password: get %s for %s (%s)\" format \"%s %s:%s\" gethash \"auth-source-user-or-password: cached %s=%s for %s (%s)\" \"password\" \"SECRET\" --cl-block-nil-- (byte-code \"\\306\b	\\\"\\307\x1a\\211^[\\203]\0\v@\x12\\310\f\\311\n\\312\\\"\bC\\313\\314	\\\"C\\315	!%\\211\x15\\203Q\0\\316\\317\\320\f\\321\f\\235\\2032\0\\322\\2023\0\r\b	&\x06\\210\x0e\x16\\203A\0\r\\202C\0\r\\242\x15\x0e\x17\\203Q\0\\323\x0e\x18\r\x0e\x19#\\210\\324\\325\r\\\"\\210\vA\\211\x13\\204\v\0*\\307\\207\" [host protocol choice --cl-dolist-temp-- mode found auth-source-pick nil netrc-machine-user-or-password plist-get :source format \"%s\" auth-source-protocol-defaults gnus-message 9 \"auth-source-user-or-password: found %s=%s for %s (%s)\" \"password\" \"SECRET\" puthash throw --cl-block-nil-- listy auth-source-do-cache cname auth-source-cache] 8) found] 8 (\"/usr/share/emacs/23.1/lisp/gnus/auth-source.elc\" . 3601)], 5")
  apply(message "Unable to open server nnimap+ltw due to: Wrong number of arguments: #[(mode host protocol) \"\\306\\307\\310\b	\n%\\210\b<\\211^[\\203\x13\0\b\\202\x15\0\bC\x18\\311\\312\b	\n$\x1c\\313\f\r\\\"\\211\x1e\x11\\203A\0\\306\\307\\314\b\\315\b\\235\\2035\0\\316\\2027\0\x0e\x11	\n&\x06\\210\x0e\x11\\202D\0\\317\\320\\215,\\207\" [mode host protocol listy cname auth-source-cache gnus-message 9 \"auth-source-user-or-password: get %s for %s (%s)\" format \"%s %s:%s\" gethash \"auth-source-user-or-password: cached %s=%s for %s (%s)\" \"password\" \"SECRET\" --cl-block-nil-- (byte-code \"\\306\b	\\\"\\307\x1a\\211^[\\203]\0\v@\x12\\310\f\\311\n\\312\\\"\bC\\313\\314	\\\"C\\315	!%\\211\x15\\203Q\0\\316\\317\\320\f\\321\f\\235\\2032\0\\322\\2023\0\r\b	&\x06\\210\x0e\x16\\203A\0\r\\202C\0\r\\242\x15\x0e\x17\\203Q\0\\323\x0e\x18\r\x0e\x19#\\210\\324\\325\r\\\"\\210\vA\\211\x13\\204\v\0*\\307\\207\" [host protocol choice --cl-dolist-temp-- mode found auth-source-pick nil netrc-machine-user-or-password plist-get :source format \"%s\" auth-source-protocol-defaults gnus-message 9 \"auth-source-user-or-password: found %s=%s for %s (%s)\" \"password\" \"SECRET\" puthash throw --cl-block-nil-- listy auth-source-do-cache cname auth-source-cache] 8) found] 8 (\"/usr/share/emacs/23.1/lisp/gnus/auth-source.elc\" . 3601)], 5")
  gnus-message(1 "Unable to open server nnimap+ltw due to: Wrong number of arguments: #[(mode host protocol) \"\\306\\307\\310\b	\n%\\210\b<\\211^[\\203\x13\0\b\\202\x15\0\bC\x18\\311\\312\b	\n$\x1c\\313\f\r\\\"\\211\x1e\x11\\203A\0\\306\\307\\314\b\\315\b\\235\\2035\0\\316\\2027\0\x0e\x11	\n&\x06\\210\x0e\x11\\202D\0\\317\\320\\215,\\207\" [mode host protocol listy cname auth-source-cache gnus-message 9 \"auth-source-user-or-password: get %s for %s (%s)\" format \"%s %s:%s\" gethash \"auth-source-user-or-password: cached %s=%s for %s (%s)\" \"password\" \"SECRET\" --cl-block-nil-- (byte-code \"\\306\b	\\\"\\307\x1a\\211^[\\203]\0\v@\x12\\310\f\\311\n\\312\\\"\bC\\313\\314	\\\"C\\315	!%\\211\x15\\203Q\0\\316\\317\\320\f\\321\f\\235\\2032\0\\322\\2023\0\r\b	&\x06\\210\x0e\x16\\203A\0\r\\202C\0\r\\242\x15\x0e\x17\\203Q\0\\323\x0e\x18\r\x0e\x19#\\210\\324\\325\r\\\"\\210\vA\\211\x13\\204\v\0*\\307\\207\" [host protocol choice --cl-dolist-temp-- mode found auth-source-pick nil netrc-machine-user-or-password plist-get :source format \"%s\" auth-source-protocol-defaults gnus-message 9 \"auth-source-user-or-password: found %s=%s for %s (%s)\" \"password\" \"SECRET\" puthash throw --cl-block-nil-- listy auth-source-do-cache cname auth-source-cache] 8) found] 8 (\"/usr/share/emacs/23.1/lisp/gnus/auth-source.elc\" . 3601)], 5")
  byte-code("ÂÃÄÅ\bÆ	!#\"ˆÇ‡" [server err gnus-message 1 format "Unable to open server %s due to: %s" error-message-string nil] 7)
  gnus-open-server((nnimap "ltw" (nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))
  gnus-check-server((nnimap "ltw" (nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))
  gnus-read-active-file-1((nnimap "ltw" (nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)) nil)
  gnus-read-active-file(nil nil)
  gnus-setup-news(nil nil nil)
  byte-code("\b„\x0e\0	„\x0e\0Æ ˆ‚Q\0ÇÈ!ˆÉ\n!\x13\f„\x1e\0\rƒ!\0Ê ˆ\x0e\x1aƒ+\0ËÌÍ\"ˆËÎÏ\"ˆÐÑ\x0e^[\b#ˆÇÒ!ˆÓ ˆÔ\x0e^[!ˆÕ ˆÖ×!ˆØ ˆÇÙ!ˆÑ‡" [dont-connect did-connect gnus-startup-file gnus-current-startup-file gnus-slave gnus-use-dribble-file gnus-group-quit gnus-run-hooks gnus-startup-hook gnus-make-newsrc-file gnus-dribble-read-file gnus-request-create-group "queue" (nndraft "") "drafts" (nndraft "") gnus-setup-news nil gnus-setup-news-hook gnus-start-draft-setup gnus-group-list-groups gnus-group-first-unread-group gnus-configure-windows group gnus-group-set-mode-line gnus-started-hook gnus-agent level] 4)
  gnus-1(nil nil nil)
  gnus(nil)
  call-interactively(gnus t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)


-- 
Have you ever considered how much text can fit in eighty columns?  Given that a
signature typically contains up to four lines of text, this space allows you to
attach a tremendous amount of valuable information to your messages.  Seize the
opportunity and don't waste your signature on bullshit that nobody cares about.

Re: Not enough arguments for format string

[Lars Magne Ingebrigtsen]

Frank Schmitt <ich@frank-schmitt.net> writes:

> I just did a git pull and starting gnus resulted in an error while
> trying to open the IMAP server:

Hm.  That backtrace was a bit difficult to interpret.  Could you try
evaling this?

(nnimap-open-server "ltw" '((nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))

But the backtrace seemed to be saying something about auth-sources.
What the value of your `auth-source-debug' variable?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Not enough arguments for format string

[Frank Schmitt]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Frank Schmitt <ich@frank-schmitt.net> writes:
>
>> I just did a git pull and starting gnus resulted in an error while
>> trying to open the IMAP server:
>
> Hm.  That backtrace was a bit difficult to interpret.  Could you try
> evaling this?
>
> (nnimap-open-server "ltw" '((nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))

This gives t

> But the backtrace seemed to be saying something about auth-sources.
> What the value of your `auth-source-debug' variable?

Hmm. I don't have it.
Debugger entered--Lisp error: (void-variable auth-source-debug)
this after evaling in scratch after the unsuccessful attempt to start gnus.

-- 
Have you ever considered how much text can fit in eighty columns?  Given that a
signature typically contains up to four lines of text, this space allows you to
attach a tremendous amount of valuable information to your messages.  Seize the
opportunity and don't waste your signature on bullshit that nobody cares about.

Re: Not enough arguments for format string

[Lars Magne Ingebrigtsen]

Frank Schmitt <ich@frank-schmitt.net> writes:

>> (nnimap-open-server "ltw" '((nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))
>
> This gives t
>
>> But the backtrace seemed to be saying something about auth-sources.
>> What the value of your `auth-source-debug' variable?
>
> Hmm. I don't have it.
> Debugger entered--Lisp error: (void-variable auth-source-debug)
> this after evaling in scratch after the unsuccessful attempt to start gnus.

Hm.  *scratches head*  Your backtrace had stuff like:

  apply(message "Unable to open server nnimap+ltw due to: Wrong number of arguments: #[(mode host protocol)

  [...]

  gnus-open-server((nnimap "ltw" (nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))

And the only place I can find "mode host protocol" is in auth-source.el.
Which defines that debug variable.

You don't happen to have an older auth-source in your load path
somewhere?  What does M-x locate-library auth-source say?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Not enough arguments for format string

[Frank Schmitt]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>>> But the backtrace seemed to be saying something about auth-sources.
>>> What the value of your `auth-source-debug' variable?
>>
>> Hmm. I don't have it.
>> Debugger entered--Lisp error: (void-variable auth-source-debug)
>> this after evaling in scratch after the unsuccessful attempt to start gnus.
>
> Hm.  *scratches head*  Your backtrace had stuff like:
>
>   apply(message "Unable to open server nnimap+ltw due to: Wrong number of arguments: #[(mode host protocol)
>
>   [...]
>
>   gnus-open-server((nnimap "ltw" (nnimap-address "ltw.loris.tv") (nnimap-stream ssl) (nnimap-authenticator login)))
>
> And the only place I can find "mode host protocol" is in auth-source.el.
> Which defines that debug variable.
>
> You don't happen to have an older auth-source in your load path
> somewhere?  What does M-x locate-library auth-source say?

This is *really* strange. It correctly says "Library is file
~/gnus/lisp/auth-source.elc" however during the failed attempt to
authenticate I get the following (look at the last line!)

Opening nnimap server on ltw...
Opening TLS connection to `ltw.loris.tv'...
Opening TLS connection with `gnutls-cli -p imaps ltw.loris.tv'...failed
Opening TLS connection with `gnutls-cli -p imaps ltw.loris.tv
--protocols ssl3'...failed
Opening TLS connection with `openssl s_client -connect
ltw.loris.tv:imaps -no_ssl2 -ign_eof'...done
Opening TLS connection to `ltw.loris.tv'...done
Unable to open server nnimap+ltw due to: Wrong number of arguments:
#[(mode host protocol) "\306\307\310^H
%\210^H<\211^[\203^S^@^H\202^U^@^HC^X\311\312^H
$^\\313^L^M\"\211^^^Q\203A^@\306\307\314^H\315^H\235\2035^@\316\2027^@^N^Q
&^F\210^N^Q\202D^@\317\320\215,\207" [mode host protocol listy cname
auth-source-cache gnus-message 9 "auth-source-user-o\
r-password: get %s for %s (%s)" format "%s %s:%s" gethash
"auth-source-user-or-password: cached %s=%s for %s (%s)" "passw\
ord" "SECRET" --cl-block-nil-- (byte-code "\306^H
\"\307^Z\211^[\203]^@^K@^R\310^L\311
\312\"^HC\313\314 \"C\315
!%\211^U\203Q^@\316\317\320^L\321^L\235\2032^@\322\2023^@^M^H
&^F\210^N^V\203A^@^M\202C^@^M\242\
^U^N^W\203Q^@\323^N^X^M^N^Y#\210\324\325^M\"\210^KA\211^S\204^K^@*\307\207"
[host protocol choice --cl-dolist-temp-- mode\
 found auth-source-pick nil netrc-machine-user-or-password plist-get
 :source format "%s" auth-source-protocol-defaults gn\
us-message 9 "auth-source-user-or-password: found %s=%s for %s (%s)"
"password" "SECRET" puthash throw --cl-block-nil-- l\
isty auth-source-do-cache cname auth-source-cache] 8) found] 8
("/usr/share/emacs/23.1/lisp/gnus/auth-source.elc" . 3601)\
], 5

What could be wrong there? I have 

(setq load-path (cons (expand-file-name "~/gnus/lisp") load-path))
(require 'gnus-load)

in .emacs.

-- 
Have you ever considered how much text can fit in eighty columns?  Given that a
signature typically contains up to four lines of text, this space allows you to
attach a tremendous amount of valuable information to your messages.  Seize the
opportunity and don't waste your signature on bullshit that nobody cares about.

Re: Not enough arguments for format string

[Lars Magne Ingebrigtsen]

Frank Schmitt <ich@frank-schmitt.net> writes:

> This is *really* strange. It correctly says "Library is file
> ~/gnus/lisp/auth-source.elc" however during the failed attempt to
> authenticate I get the following (look at the last line!)

[...]

> ("/usr/share/emacs/23.1/lisp/gnus/auth-source.elc" . 3601)\
> ], 5
>
> What could be wrong there? I have 
>
> (setq load-path (cons (expand-file-name "~/gnus/lisp") load-path))
> (require 'gnus-load)

Something must be altering your load path between your putting
~/gnus/lisp onto it and before you start Gnus.

Have a peek at the load-path variable just before you say `M-x gnus' and
see what it says.

Alternatively, something may have loaded auth-source before you add
~/gnus/lisp to it...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Not enough arguments for format string

[Frank Schmitt]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Alternatively, something may have loaded auth-source before you add
> ~/gnus/lisp to it...

Yes, that was it. Thanks.

-- 
Have you ever considered how much text can fit in eighty columns?  Given that a
signature typically contains up to four lines of text, this space allows you to
attach a tremendous amount of valuable information to your messages.  Seize the
opportunity and don't waste your signature on bullshit that nobody cares about.

[PATCH] Pass proper format string to gnus-message

[Andreas Schwab]

---
 lisp/ChangeLog     |   16 ++++++++++++++++
 lisp/gnus-agent.el |    6 +++---
 lisp/gnus-art.el   |    4 ++--
 lisp/gnus-group.el |   14 ++++++--------
 lisp/gnus-int.el   |    5 ++---
 lisp/gnus-score.el |   10 +++++-----
 lisp/gnus-srvr.el  |    2 +-
 lisp/gnus-start.el |    4 ++--
 lisp/gnus-sum.el   |    2 +-
 9 files changed, 38 insertions(+), 25 deletions(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 22cca6e..3d8fb27 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,19 @@
+2010-09-19  Andreas Schwab  <schwab@linux-m68k.org>
+
+	* gnus-agent.el (gnus-agent-batch-confirmation)
+	(gnus-agent-expire-group, gnus-agent-expire): Pass proper format string
+	to gnus-message.
+	* gnus-art.el (gnus-article-describe-briefly): Likewise.
+	* gnus-group.el (gnus-group-list-groups, gnus-group-describe-group)
+	(gnus-group-edit-global-kill, gnus-group-describe-briefly): Likewise.
+	* gnus-int.el (gnus-open-server): Likewise.
+	* gnus-score.el (gnus-score-edit-current-scores, gnus-score-edit-file)
+	(gnus-score-check-syntax): Likewise.
+	* gnus-srvr.el (gnus-browse-describe-briefly): Likewise.
+	* gnus-start.el (gnus-read-active-file-1, gnus-read-active-file-1):
+	Likewise.
+	* gnus-sum.el (gnus-summary-describe-briefly): Likewise.
+
 2010-09-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
 	* gnus-agent.el (gnus-agent-auto-agentize-methods): Switch the default
diff --git a/lisp/gnus-agent.el b/lisp/gnus-agent.el
index 781ea3b..2a586e6 100644
--- a/lisp/gnus-agent.el
+++ b/lisp/gnus-agent.el
@@ -2377,7 +2377,7 @@ modified) original contents, they are first saved to their own file."
 
 (defun gnus-agent-batch-confirmation (msg)
   "Show error message and return t."
-  (gnus-message 1 msg)
+  (gnus-message 1 "%s" msg)
   t)
 
 ;;;###autoload
@@ -3123,7 +3123,7 @@ FORCE is equivalent to setting the expiration predicates to true."
                        group overview (gnus-gethash-safe group orig)
                        articles force))))
               (kill-buffer overview))))
-      (gnus-message 4 (gnus-agent-expire-done-message)))))
+      (gnus-message 4 "%s" (gnus-agent-expire-done-message)))))
 
 (defun gnus-agent-expire-group-1 (group overview active articles force)
   ;; Internal function - requires caller to have set
@@ -3548,7 +3548,7 @@ articles in every agentized group? "))
                              expiring-group overview active articles force))))))))
             (kill-buffer overview))
           (gnus-agent-expire-unagentized-dirs)
-          (gnus-message 4 (gnus-agent-expire-done-message))))))
+          (gnus-message 4 "%s" (gnus-agent-expire-done-message))))))
 
 (defun gnus-agent-expire-done-message ()
   (if (and (> gnus-verbose 4)
diff --git a/lisp/gnus-art.el b/lisp/gnus-art.el
index bfdb9bd..f533fcd 100644
--- a/lisp/gnus-art.el
+++ b/lisp/gnus-art.el
@@ -6405,8 +6405,8 @@ not have a face in `gnus-article-boring-faces'."
 
 (defun gnus-article-describe-briefly ()
   "Describe article mode commands briefly."
-  (interactive)
-  (gnus-message 6 (substitute-command-keys "\\<gnus-article-mode-map>\\[gnus-article-goto-next-page]:Next page	 \\[gnus-article-goto-prev-page]:Prev page  \\[gnus-article-show-summary]:Show summary  \\[gnus-info-find-node]:Run Info  \\[gnus-article-describe-briefly]:This help")))
+  (interactive)5
+  (gnus-message 6 "%s" (substitute-command-keys "\\<gnus-article-mode-map>\\[gnus-article-goto-next-page]:Next page	 \\[gnus-article-goto-prev-page]:Prev page  \\[gnus-article-show-summary]:Show summary  \\[gnus-info-find-node]:Run Info  \\[gnus-article-describe-briefly]:This help")))
 
 (defun gnus-article-check-buffer ()
   "Beep if not in an article buffer."
diff --git a/lisp/gnus-group.el b/lisp/gnus-group.el
index 5cc4ef6..fa6ae51 100644
--- a/lisp/gnus-group.el
+++ b/lisp/gnus-group.el
@@ -1273,7 +1273,7 @@ Also see the `gnus-group-use-permanent-levels' variable."
 		   (zerop number))
 	      (zerop (buffer-size)))
       ;; No groups in the buffer.
-      (gnus-message 5 gnus-no-groups-message))
+      (gnus-message 5 "%s" gnus-no-groups-message))
     ;; We have some groups displayed.
     (goto-char (point-max))
     (when (or (not gnus-group-goto-next-group-function)
@@ -4136,7 +4136,7 @@ If given a prefix argument, prompt for a group."
 		   (gnus-gethash mname gnus-description-hashtb))
 	      (setq desc (gnus-group-get-description group))
 	      (gnus-read-descriptions-file method))
-      (gnus-message 1
+      (gnus-message 1 "%s"
 		    (or desc (gnus-gethash group gnus-description-hashtb)
 			"No description available")))))
 
@@ -4297,11 +4297,9 @@ If GROUP, edit that local kill file instead."
   (interactive "P")
   (setq gnus-current-kill-article article)
   (gnus-kill-file-edit-file group)
-  (gnus-message
-   6
-   (substitute-command-keys
-    (format "Editing a %s kill file (Type \\[gnus-kill-file-exit] to exit)"
-	    (if group "local" "global")))))
+  (gnus-message 6 "Editing a %s kill file (Type %s to exit)"
+		(if group "local" "global")
+		(substitute-command-keys "\\[gnus-kill-file-exit]")))
 
 (defun gnus-group-edit-local-kill (article group)
   "Edit a local kill file."
@@ -4392,7 +4390,7 @@ The hook `gnus-exit-gnus-hook' is called before actually exiting."
 (defun gnus-group-describe-briefly ()
   "Give a one line description of the group mode commands."
   (interactive)
-  (gnus-message 7 (substitute-command-keys "\\<gnus-group-mode-map>\\[gnus-group-read-group]:Select  \\[gnus-group-next-unread-group]:Forward  \\[gnus-group-prev-unread-group]:Backward  \\[gnus-group-exit]:Exit  \\[gnus-info-find-node]:Run Info  \\[gnus-group-describe-briefly]:This help")))
+  (gnus-message 7 "%s" (substitute-command-keys "\\<gnus-group-mode-map>\\[gnus-group-read-group]:Select  \\[gnus-group-next-unread-group]:Forward  \\[gnus-group-prev-unread-group]:Backward  \\[gnus-group-exit]:Exit  \\[gnus-info-find-node]:Run Info  \\[gnus-group-describe-briefly]:This help")))
 
 (defun gnus-group-browse-foreign-server (method)
   "Browse a foreign news server.
diff --git a/lisp/gnus-int.el b/lisp/gnus-int.el
index bcfc015..f245907 100644
--- a/lisp/gnus-int.el
+++ b/lisp/gnus-int.el
@@ -245,9 +245,8 @@ If it is down, start it up (again)."
                           (nth 1 gnus-command-method)
                           (nthcdr 2 gnus-command-method))
                (error
-                (gnus-message 1 (format
-                                 "Unable to open server %s due to: %s"
-                                 server (error-message-string err)))
+                (gnus-message 1 "Unable to open server %s due to: %s"
+			      server (error-message-string err))
                 nil)
                (quit
                 (gnus-message 1 "Quit trying to open server %s" server)
diff --git a/lisp/gnus-score.el b/lisp/gnus-score.el
index 5cd60dd..03ff30d 100644
--- a/lisp/gnus-score.el
+++ b/lisp/gnus-score.el
@@ -1114,8 +1114,8 @@ EXTRA is the possible non-standard header."
       (make-local-variable 'gnus-prev-winconf)
       (setq gnus-prev-winconf winconf))
     (gnus-message
-     4 (substitute-command-keys
-	"\\<gnus-score-mode-map>\\[gnus-score-edit-exit] to save edits"))))
+     4 "%s" (substitute-command-keys
+	     "\\<gnus-score-mode-map>\\[gnus-score-edit-exit] to save edits"))))
 
 (defun gnus-score-edit-all-score ()
   "Edit the all.SCORE file."
@@ -1142,8 +1142,8 @@ EXTRA is the possible non-standard header."
     (make-local-variable 'gnus-prev-winconf)
     (setq gnus-prev-winconf winconf))
   (gnus-message
-   4 (substitute-command-keys
-      "\\<gnus-score-mode-map>\\[gnus-score-edit-exit] to save edits")))
+   4 "%s" (substitute-command-keys
+	   "\\<gnus-score-mode-map>\\[gnus-score-edit-exit] to save edits")))
 
 (defun gnus-score-edit-file-at-point (&optional format)
   "Edit score file at point in Score Trace buffers.
@@ -1391,7 +1391,7 @@ If FORMAT, also format the current score file."
       (if err
 	  (progn
 	    (ding)
-	    (gnus-message 3 err)
+	    (gnus-message 3 "%s" err)
 	    (sit-for 2)
 	    nil)
 	alist)))))
diff --git a/lisp/gnus-srvr.el b/lisp/gnus-srvr.el
index dd5e518..2966212 100644
--- a/lisp/gnus-srvr.el
+++ b/lisp/gnus-srvr.el
@@ -976,7 +976,7 @@ If NUMBER, fetch this number of articles."
 (defun gnus-browse-describe-briefly ()
   "Give a one line description of the group mode commands."
   (interactive)
-  (gnus-message 6
+  (gnus-message 6 "%s"
 		(substitute-command-keys "\\<gnus-browse-mode-map>\\[gnus-group-next-group]:Forward  \\[gnus-group-prev-group]:Backward  \\[gnus-browse-exit]:Exit  \\[gnus-info-find-node]:Run Info  \\[gnus-browse-describe-briefly]:This help")))
 
 (defun gnus-server-regenerate-server ()
diff --git a/lisp/gnus-start.el b/lisp/gnus-start.el
index 1855307..d78a2f8 100644
--- a/lisp/gnus-start.el
+++ b/lisp/gnus-start.el
@@ -2054,7 +2054,7 @@ If SCAN, request a scan of that group as well."
 		       (if (and where (not (zerop (length where))))
 			   (concat " from " where) "")
 		       (car method)))
-    (gnus-message 5 mesg)
+    (gnus-message 5 "%s" mesg)
     (when (gnus-check-server method)
       ;; Request that the backend scan its incoming messages.
       (when (and (or (and gnus-agent
@@ -2089,7 +2089,7 @@ If SCAN, request a scan of that group as well."
 	    (unless (equal method gnus-message-archive-method)
 	      (gnus-error 1 "Cannot read active file from %s server"
 			  (car method)))
-	  (gnus-message 5 mesg)
+	  (gnus-message 5 "%s" mesg)
 	  (gnus-active-to-gnus-format method gnus-active-hashtb nil t)
 	  ;; We mark this active file as read.
 	  (push method gnus-have-read-active-file)
diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
index 3c3a059..e09c3a5 100644
--- a/lisp/gnus-sum.el
+++ b/lisp/gnus-sum.el
@@ -7330,7 +7330,7 @@ in."
 (defun gnus-summary-describe-briefly ()
   "Describe summary mode commands briefly."
   (interactive)
-  (gnus-message 6 (substitute-command-keys "\\<gnus-summary-mode-map>\\[gnus-summary-next-page]:Select  \\[gnus-summary-next-unread-article]:Forward  \\[gnus-summary-prev-unread-article]:Backward  \\[gnus-summary-exit]:Exit  \\[gnus-info-find-node]:Run Info	 \\[gnus-summary-describe-briefly]:This help")))
+  (gnus-message 6 "%s" (substitute-command-keys "\\<gnus-summary-mode-map>\\[gnus-summary-next-page]:Select  \\[gnus-summary-next-unread-article]:Forward  \\[gnus-summary-prev-unread-article]:Backward  \\[gnus-summary-exit]:Exit  \\[gnus-info-find-node]:Run Info	 \\[gnus-summary-describe-briefly]:This help")))
 
 ;; Walking around group mode buffer from summary mode.
 
-- 
1.7.2.3


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] Pass proper format string to gnus-message

[Knut Anders Hatlen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> diff --git a/lisp/gnus-art.el b/lisp/gnus-art.el
> index bfdb9bd..f533fcd 100644
> --- a/lisp/gnus-art.el
> +++ b/lisp/gnus-art.el
> @@ -6405,8 +6405,8 @@ not have a face in `gnus-article-boring-faces'."
>  
>  (defun gnus-article-describe-briefly ()
>    "Describe article mode commands briefly."
> -  (interactive)
> -  (gnus-message 6 (substitute-command-keys "\\<gnus-article-mode-map>\\[gnus-article-goto-next-page]:Next page	 \\[gnus-article-goto-prev-page]:Prev page  \\[gnus-article-show-summary]:Show summary  \\[gnus-info-find-node]:Run Info  \\[gnus-article-describe-briefly]:This help")))
> +  (interactive)5
                  ^
I suppose the number 5 on this line was unintended?

-- 
Knut Anders

Re: [PATCH] Pass proper format string to gnus-message

[Lars Magne Ingebrigtsen]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

>> +  (interactive)5
>                   ^
> I suppose the number 5 on this line was unintended?

Good catch.  Fixed and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [PATCH] Pass proper format string to gnus-message

[Lars Magne Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> +	(gnus-agent-expire-group, gnus-agent-expire): Pass proper format string
> +	to gnus-message.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen