Re: Documentation & Keybinding for `gnus-article-browse-html-article'

[Hynek Schlawack <hs+ding@ox.cx>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

>>> And last but not least, where would you put the documentation to? Is
>>> this really `washing'? I'm a bit baffled in this point. :)
>>
>> This isn't really "washing" -- it's more akin to
>> `gnus-article-view-part-externally', which is bound to `K e'.  So I'd
>> suggest `K H' for the binding, and put it in the same
>> menu/documentation node as `K e'.
> Hynek, could you provide a patch following Larsi's suggestions?

I'm sorry, that I've been really busy in the last weeks so I haven't
been able to follow this list and I've missed his mail. :(

The patch for a key binding is straight forward:

--8<---------------cut here---------------start------------->8---
Index: lisp/gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 7.172
diff -u -r7.172 gnus-art.el
--- lisp/gnus-art.el	16 May 2006 09:40:32 -0000	7.172
+++ lisp/gnus-art.el	23 May 2006 12:06:07 -0000
@@ -2708,7 +2708,6 @@
 			      (gnus-article-browse-html-parts handle))))))))
     showed))
 
-;; TODO: Key binding
 (defun gnus-article-browse-html-article ()
   "View \"text/html\" parts of the current article with a WWW browser."
   (interactive)
Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 7.145
diff -u -r7.145 gnus-sum.el
--- lisp/gnus-sum.el	19 May 2006 00:00:51 -0000	7.145
+++ lisp/gnus-sum.el	23 May 2006 12:06:07 -0000
@@ -2092,6 +2092,7 @@
   "c" gnus-article-copy-part
   "C" gnus-article-view-part-as-charset
   "e" gnus-article-view-part-externally
+  "H" gnus-article-browse-html-article
   "E" gnus-article-encrypt-body
   "i" gnus-article-inline-part
   "|" gnus-article-pipe-part)
@@ -2128,7 +2129,8 @@
   "b" gnus-uu-decode-binhex
   "B" gnus-uu-decode-binhex
   "p" gnus-uu-decode-postscript
-  "P" gnus-uu-decode-postscript-and-save)
+  "P" gnus-uu-decode-postscript-and-save
+  "H" gnus-article-browse-html-article)
 
 (gnus-define-keys
     (gnus-uu-extract-view-map "v" gnus-uu-extract-map)
--8<---------------cut here---------------end--------------->8---

The docs are a bit trickier though:

> BTW, (info "(gnus)Saving Articles") also has similar commands:
>
> ,----[ (info "(gnus)Saving Articles") ]
> | `O p'
> | `|'
> |      Save the current article in a pipe.  [...]
> | 
> | `O P'
> |      Save the current article into muttprint.  [...]
> `----
>
> But `gnus-article-browse-html-article' doesn't use the process/prefix
> convention (maybe it could be extended to use it?):
>
> ,----[ (info "(gnus)Saving Articles") ]
> |    All these commands use the process/prefix convention (*note
> | Process/Prefix::).
> `----

I'd put it into (info "(gnus)MIME Commands"), I'll have to implement:

,----[ (info "(gnus)MIME Commands") ]
| The following commands all understand the numerical prefix.  For
| instance, `3 b' means "view the third MIME part".
`----

Any `best practices'? ;) Unfortunately, the list of attachments is
recursive, so I guess I'll have to use a counter. Any other (more
elegant) ideas?

-hs