From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63244 Path: news.gmane.org!not-for-mail From: Hynek Schlawack Newsgroups: gmane.emacs.gnus.general Subject: Re: Documentation & Keybinding for `gnus-article-browse-html-article' Date: Tue, 23 May 2006 14:43:48 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1148388395 27448 80.91.229.2 (23 May 2006 12:46:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 May 2006 12:46:35 +0000 (UTC) Original-X-From: ding-owner+m11771@lists.math.uh.edu Tue May 23 14:46:30 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FiWH5-0000AI-Ew for ding-account@gmane.org; Tue, 23 May 2006 14:46:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FiWH0-0003qE-00; Tue, 23 May 2006 07:46:06 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FiWEp-0003q9-00 for ding@lists.math.uh.edu; Tue, 23 May 2006 07:43:51 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FiWEn-0003Gc-OK for ding@lists.math.uh.edu; Tue, 23 May 2006 07:43:51 -0500 Original-Received: from relay1.mail.vrmd.de ([81.28.232.18]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FiWEm-000408-00 for ; Tue, 23 May 2006 14:43:48 +0200 Original-Received: from [141.89.59.172] (helo=sanday.haiti.cs.uni-potsdam.de) by relay1.mail.vrmd.de with esmtpa (Exim 4.60) (envelope-from ) id 1FiWEm-0004dL-CZ for ding@gnus.org; Tue, 23 May 2006 14:43:48 +0200 Original-To: ding@gnus.org In-Reply-To: (Reiner Steib's message of "Thu, 18 May 2006 15:32:57 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Relay-User: mailout@ularx.de X-Spam-Score: -1.7 (-) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63244 Archived-At: Reiner Steib writes: >>> And last but not least, where would you put the documentation to? Is >>> this really `washing'? I'm a bit baffled in this point. :) >> >> This isn't really "washing" -- it's more akin to >> `gnus-article-view-part-externally', which is bound to `K e'. So I'd >> suggest `K H' for the binding, and put it in the same >> menu/documentation node as `K e'. > Hynek, could you provide a patch following Larsi's suggestions? I'm sorry, that I've been really busy in the last weeks so I haven't been able to follow this list and I've missed his mail. :( The patch for a key binding is straight forward: --8<---------------cut here---------------start------------->8--- Index: lisp/gnus-art.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v retrieving revision 7.172 diff -u -r7.172 gnus-art.el --- lisp/gnus-art.el 16 May 2006 09:40:32 -0000 7.172 +++ lisp/gnus-art.el 23 May 2006 12:06:07 -0000 @@ -2708,7 +2708,6 @@ (gnus-article-browse-html-parts handle)))))))) showed)) -;; TODO: Key binding (defun gnus-article-browse-html-article () "View \"text/html\" parts of the current article with a WWW browser." (interactive) Index: lisp/gnus-sum.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v retrieving revision 7.145 diff -u -r7.145 gnus-sum.el --- lisp/gnus-sum.el 19 May 2006 00:00:51 -0000 7.145 +++ lisp/gnus-sum.el 23 May 2006 12:06:07 -0000 @@ -2092,6 +2092,7 @@ "c" gnus-article-copy-part "C" gnus-article-view-part-as-charset "e" gnus-article-view-part-externally + "H" gnus-article-browse-html-article "E" gnus-article-encrypt-body "i" gnus-article-inline-part "|" gnus-article-pipe-part) @@ -2128,7 +2129,8 @@ "b" gnus-uu-decode-binhex "B" gnus-uu-decode-binhex "p" gnus-uu-decode-postscript - "P" gnus-uu-decode-postscript-and-save) + "P" gnus-uu-decode-postscript-and-save + "H" gnus-article-browse-html-article) (gnus-define-keys (gnus-uu-extract-view-map "v" gnus-uu-extract-map) --8<---------------cut here---------------end--------------->8--- The docs are a bit trickier though: > BTW, (info "(gnus)Saving Articles") also has similar commands: > > ,----[ (info "(gnus)Saving Articles") ] > | `O p' > | `|' > | Save the current article in a pipe. [...] > | > | `O P' > | Save the current article into muttprint. [...] > `---- > > But `gnus-article-browse-html-article' doesn't use the process/prefix > convention (maybe it could be extended to use it?): > > ,----[ (info "(gnus)Saving Articles") ] > | All these commands use the process/prefix convention (*note > | Process/Prefix::). > `---- I'd put it into (info "(gnus)MIME Commands"), I'll have to implement: ,----[ (info "(gnus)MIME Commands") ] | The following commands all understand the numerical prefix. For | instance, `3 b' means "view the third MIME part". `---- Any `best practices'? ;) Unfortunately, the list of attachments is recursive, so I guess I'll have to use a counter. Any other (more elegant) ideas? -hs