Gnus development mailing list
 help / color / mirror / Atom feed
From: Dan Christensen <jdc@chow.mat.jhu.edu>
Subject: Re: spontaneous nnfolder message deletion
Date: Thu, 07 May 1998 16:58:13 -0400	[thread overview]
Message-ID: <x7g1ilvlwa.fsf@chow.mat.jhu.edu> (raw)
In-Reply-To: Danny Siu's message of "07 May 1998 10:20:33 -0700"

Danny Siu <dsiu@Adobe.COM> writes:
> Dan Christensen writes:
>   Dan> This is related to a patch I sent Lars last week.  I don't know if
>   Dan> the problem will show up for users of 5.6.9.  I've fixed the problem
>   Dan> and am about to send a patch to the patch to Lars.
> 
> I had more than a dozen of messages automagically deleted in my nnfolders!
> Fortunately, I had nnmail-delete-incoming set to nil and not much damage has
> been done.  Can you post the patch before 5.6.10 comes out?

Well, at least this means that my latest patch isn't entirely to blame.
Here's a patch to nnfolder which makes nnfolder-delete-mail less 
aggressive.  The line numbers might not match exactly how things
are in 5.6.9.  In fact, I haven't tested this with stock 5.6.9
(ie. without the patch mentioned above), so please let me know if
it works.

Dan

*** nnfolder.el	Wed May  6 16:33:51 1998
--- nnfolder.el.old	Fri May  1 17:26:14 1998
***************
*** 505,525 ****
  	   (not (search-forward "\n\n" pos t))))))
  
  (defun nnfolder-delete-mail (&optional force leave-delim)
!   "Delete the message that point is in.  Optional argument
! FORCE ignored.  If optional argument LEAVE-DELIM is t,
! then mailbox delimiter is not deleted.  Point is left
! where the deleted region was."
!   (delete-region
!    (save-excursion
!      (forward-line 1) ; in case point is at beginning of message already
!      (nnmail-search-unix-mail-delim-backward)
!      (if leave-delim (progn (forward-line 1) (point))
!        (point)))
!    (progn
!      (forward-line 1)
!      (if (nnmail-search-unix-mail-delim)
! 	 (point)
!        (point-max)))))
  
  (defun nnfolder-possibly-change-group (group &optional server dont-check)
    ;; Change servers.
--- 506,523 ----
  	   (not (search-forward "\n\n" pos t))))))
  
  (defun nnfolder-delete-mail (&optional force leave-delim)
!   "Delete the message that point is in."
!   (save-excursion
!     (delete-region
!      (save-excursion
!        (nnmail-search-unix-mail-delim-backward)
!        (if leave-delim (progn (forward-line 1) (point))
! 	 (point)))
!      (progn
!        (forward-line 1)
!        (if (nnmail-search-unix-mail-delim)
! 	   (point)
! 	 (point-max))))))
  
  (defun nnfolder-possibly-change-group (group &optional server dont-check)
    ;; Change servers.


  reply	other threads:[~1998-05-07 20:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-05-05 22:35 Dan Christensen
1998-05-06 20:41 ` Dan Christensen
1998-05-07 17:20   ` Danny Siu
1998-05-07 20:58     ` Dan Christensen [this message]
1998-06-01 15:50       ` Danny Siu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x7g1ilvlwa.fsf@chow.mat.jhu.edu \
    --to=jdc@chow.mat.jhu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).