spontaneous nnfolder message deletion

spontaneous nnfolder message deletion

[Dan Christensen]

Is it just me, or are other people finding that 5.6.9 spontaneous
deletes messages from nnfolder groups?  I'll read a message, read
a few more, then go back to read the message and Gnus will claim
that it must have expired or been deleted.  I look in nnfolder's
directory and see that the message exists in Inbox~ but not Inbox,
for example.  This has happen to a dozen different messages today.
Luckily I have Gnus keep incoming files around...

I will report more details in a day or two -- I have to run now.

Dan

-- 
Dan Christensen
jdc@math.jhu.edu

Re: spontaneous nnfolder message deletion

[Dan Christensen]

Dan Christensen <jdc@math.jhu.edu> writes:
> Is it just me, or are other people finding that 5.6.9 spontaneous
> deletes messages from nnfolder groups?  I'll read a message, read
> a few more, then go back to read the message and Gnus will claim
> that it must have expired or been deleted.  I look in nnfolder's
> directory and see that the message exists in Inbox~ but not Inbox,
> for example.  This has happen to a dozen different messages today.

This is related to a patch I sent Lars last week.  I don't know
if the problem will show up for users of 5.6.9.  I've fixed the
problem and am about to send a patch to the patch to Lars.

Dan

-- 
Dan Christensen
jdc@math.jhu.edu

Re: spontaneous nnfolder message deletion

[Danny Siu]

Dan Christensen writes:

  Dan> Dan Christensen <jdc@math.jhu.edu> writes:
  >> Is it just me, or are other people finding that 5.6.9 spontaneous
  >> deletes messages from nnfolder groups?  I'll read a message, read a few
  >> more, then go back to read the message and Gnus will claim that it must
  >> have expired or been deleted.  I look in nnfolder's directory and see
  >> that the message exists in Inbox~ but not Inbox, for example.  This has
  >> happen to a dozen different messages today.

  Dan> This is related to a patch I sent Lars last week.  I don't know if
  Dan> the problem will show up for users of 5.6.9.  I've fixed the problem
  Dan> and am about to send a patch to the patch to Lars.

I had more than a dozen of messages automagically deleted in my nnfolders!
Fortunately, I had nnmail-delete-incoming set to nil and not much damage has
been done.  Can you post the patch before 5.6.10 comes out?

Thanks!
-- 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Danny Dick-Fung Siu                              mailto:dsiu@adobe.com 
 PSD Core Engineering              mailto:dsiu@alumni.eecs.berkeley.edu 
 Adobe Systems Incorporated          http://www.csua.berkeley.edu/~dsiu 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: spontaneous nnfolder message deletion

[Dan Christensen]

Danny Siu <dsiu@Adobe.COM> writes:
> Dan Christensen writes:
>   Dan> This is related to a patch I sent Lars last week.  I don't know if
>   Dan> the problem will show up for users of 5.6.9.  I've fixed the problem
>   Dan> and am about to send a patch to the patch to Lars.
> 
> I had more than a dozen of messages automagically deleted in my nnfolders!
> Fortunately, I had nnmail-delete-incoming set to nil and not much damage has
> been done.  Can you post the patch before 5.6.10 comes out?

Well, at least this means that my latest patch isn't entirely to blame.
Here's a patch to nnfolder which makes nnfolder-delete-mail less 
aggressive.  The line numbers might not match exactly how things
are in 5.6.9.  In fact, I haven't tested this with stock 5.6.9
(ie. without the patch mentioned above), so please let me know if
it works.

Dan

*** nnfolder.el	Wed May  6 16:33:51 1998
--- nnfolder.el.old	Fri May  1 17:26:14 1998
***************
*** 505,525 ****
  	   (not (search-forward "\n\n" pos t))))))
  
  (defun nnfolder-delete-mail (&optional force leave-delim)
!   "Delete the message that point is in.  Optional argument
! FORCE ignored.  If optional argument LEAVE-DELIM is t,
! then mailbox delimiter is not deleted.  Point is left
! where the deleted region was."
!   (delete-region
!    (save-excursion
!      (forward-line 1) ; in case point is at beginning of message already
!      (nnmail-search-unix-mail-delim-backward)
!      (if leave-delim (progn (forward-line 1) (point))
!        (point)))
!    (progn
!      (forward-line 1)
!      (if (nnmail-search-unix-mail-delim)
! 	 (point)
!        (point-max)))))
  
  (defun nnfolder-possibly-change-group (group &optional server dont-check)
    ;; Change servers.
--- 506,523 ----
  	   (not (search-forward "\n\n" pos t))))))
  
  (defun nnfolder-delete-mail (&optional force leave-delim)
!   "Delete the message that point is in."
!   (save-excursion
!     (delete-region
!      (save-excursion
!        (nnmail-search-unix-mail-delim-backward)
!        (if leave-delim (progn (forward-line 1) (point))
! 	 (point)))
!      (progn
!        (forward-line 1)
!        (if (nnmail-search-unix-mail-delim)
! 	   (point)
! 	 (point-max))))))
  
  (defun nnfolder-possibly-change-group (group &optional server dont-check)
    ;; Change servers.

Re: spontaneous nnfolder message deletion

[Danny Siu]

Dan Christensen writes:

  Dan> Danny Siu <dsiu@Adobe.COM> writes:
  >> Dan Christensen writes:
  Dan> This is related to a patch I sent Lars last week.  I don't know if
  Dan> the problem will show up for users of 5.6.9.  I've fixed the problem
  Dan> and am about to send a patch to the patch to Lars.
  >>
  >> I had more than a dozen of messages automagically deleted in my
  >> nnfolders!  Fortunately, I had nnmail-delete-incoming set to nil and
  >> not much damage has been done.  Can you post the patch before 5.6.10
  >> comes out?

  Dan> Well, at least this means that my latest patch isn't entirely to
  Dan> blame.  Here's a patch to nnfolder which makes nnfolder-delete-mail
  Dan> less aggressive.  The line numbers might not match exactly how things
  Dan> are in 5.6.9.  In fact, I haven't tested this with stock 5.6.9
  Dan> (ie. without the patch mentioned above), so please let me know if it
  Dan> works.

  Dan> Dan

  Dan> *** nnfolder.el Wed May 6 16:33:51 1998
  Dan> --- nnfolder.el.old Fri May 1 17:26:14 1998
  Dan> ***************
  Dan> *** 505,525 ****
  Dan> ...
  Dan> ...

Thanks, The patch is working.  I applied it to 5.6.9 couple weeks ago and my 
nnfolders no longer has the problem of removing extra messages.
-- 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Danny Dick-Fung Siu                              mailto:dsiu@adobe.com 
 PSD Core Engineering              mailto:dsiu@alumni.eecs.berkeley.edu 
 Adobe Systems Incorporated          http://www.csua.berkeley.edu/~dsiu 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=