Re: Viewing HTML-mails with external browsers - proposed code

[Hynek Schlawack <hynek@ularx.de>]

* Reiner Steib <reinersteib+gmane@imap.cc> wrote:

>>> we should add both functions to `gnus-art.el' and add a key binding
>>> (suggestions?) 
>> Well, _I_ use "v", but I guess I won't be able to push that. ;)
> The very few remaining single letter keys should be reserved for very
> frequently used commands.

Well, something behind an attachment-related prefix then?

> In fact, `v' is a good candidate for a (prefix) key we could reserve
> for the user in Gnus, see <news:v9u0bsv0at.fsf@marauder.physik.uni-ulm.de>.

I read it and I knew what inspired you. ;)

>>>>   (let ((showed))
>>> Maybe "done" instead of "showed"?
>> I'm not sure whether "done" exactly reflects the purpose of "showed".
> I didn't read the code very carefully, so I probably misunderstood its
> purpose.

Well, it indicates, whether a (or more) HTML-attachment has been
shown. "done" sounds like "we've done our job successfully and can
quit".

>>>> 				(make-temp-name "/tmp/gnus-html-")
>>>> 				(user-login-name))))
>>>   (mm-make-temp-file (expand-file-name "mm" mm-tmp-directory) nil ".html")
>>> Maybe even (convert-standard-filename (mm-make-temp-file ...))  like
>>> in `browse-url-of-buffer' is required?
>> Uhm, so what's your final suggestion here? :)

[...]

> We don't use `convert-standard-filename' at all in Gnus upto now.  I
> don't use those systems (Windows, DOS, Cygwin) so I'm not sure if we
> also need to add `convert-standard-filename' when we use
> `mm-make-temp-file' in Gnus.  Maybe the use in `browse-url-of-buffer'
> isn't necessary?

I'd say, mm-make-temp-file should take care of this as it also takes
care where to put the tmp-file to.

>>>>   "View HTML-parts of the current Gnus-Article in a graphical browser."
>>>     "View \"text/html\" parts of the current article with a WWW browser."
>>> See `C-h f browse-url RET'.
>> Ehm, for what exactly?
> Well, "graphical browser" might not be correct, depending on the
> user's environment and preferences.

Ok, but that's fixed now anyway.

So, there's the bug with your mail and the temp-file-stuff left, iirc?

-hs