Gnus development mailing list
 help / color / mirror / Atom feed
From: Justus-bulk@Piater.name
To: ding@gnus.org
Subject: Listing inactive groups not working?
Date: Sat, 15 Aug 2009 23:34:20 +0200	[thread overview]
Message-ID: <x8tskfsrcbn.fsf@tool.montefiore.ulg.ac.be> (raw)

Hi -

[Using Gnus v5.13 with Emacs 23.1.1 on Debian testing] 

I want to inactivate some groups by setting their level to 7, but I
still want them to be listed in the *Group* buffer with 'L'. However,
they do not appear, even though gnus-group-list-inactive-groups is t
(the default).

If the above indicates some misunderstanding on my part, please
interrupt me right here.

Otherwise I'll go on: In gnus-group-prepare-flat, I think the following
code is broken:

	(when (gnus-group-prepare-logic
	       group
	       (and unread		; This group might be unchecked
;;;; For inactive groups, unread is nil, so ...
		    (or (not (stringp regexp))
			(string-match regexp group))
		    (<= (setq clevel (gnus-info-level info)) level)
		    (>= clevel lowest)
		    (cond
		     ((functionp predicate)
		      (funcall predicate info))
		     (predicate t)	; We list all groups?
		     (t
		      (or
		       (if (eq unread t) ; Unactivated?
;;;; ... this condition is never reached:
			   gnus-group-list-inactive-groups
					; We list unactivated
			 (> unread 0))
					; We list groups with unread articles

I changed this code section into the following:

	(when (gnus-group-prepare-logic
	       group
	       (and (or unread gnus-group-list-inactive-groups)
		    (or (not (stringp regexp))
			(string-match regexp group))
		    (<= (setq clevel (gnus-info-level info)) level)
		    (>= clevel lowest)
		    (cond
		     ((functionp predicate)
		      (funcall predicate info))
		     (predicate t)	; We list all groups?
		     (t
		      (or
		       (and (integerp unread) (> unread 0))

On a limited amount of tests, this code behaves as I would expect.  Does
this make sense, or am I misunderstanding what this code is supposed to
do?

Perhaps the real problem is elsewhere: The original code appears to make
perfect sense if gnus-group-unread returns t for inactive groups, but
for me it does not - it returns nil.

Thanks,
Justus



             reply	other threads:[~2009-08-15 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-15 21:34 Justus-bulk [this message]
2009-08-15 21:53 ` Justus-bulk
2009-09-03  0:12 ` Andreas Politz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x8tskfsrcbn.fsf@tool.montefiore.ulg.ac.be \
    --to=justus-bulk@piater.name \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).