From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68905 Path: news.gmane.org!not-for-mail From: Justus-bulk@Piater.name Newsgroups: gmane.emacs.gnus.general Subject: Listing inactive groups not working? Date: Sat, 15 Aug 2009 23:34:20 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1250372179 10944 80.91.229.12 (15 Aug 2009 21:36:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Aug 2009 21:36:19 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M17325@lists.math.uh.edu Sat Aug 15 23:36:12 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1McQv6-0002lj-38 for ding-account@gmane.org; Sat, 15 Aug 2009 23:36:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1McQtv-0003Lo-AR; Sat, 15 Aug 2009 16:34:59 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1McQtt-0003La-Ih for ding@lists.math.uh.edu; Sat, 15 Aug 2009 16:34:57 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1McQts-0000NN-G0 for ding@lists.math.uh.edu; Sat, 15 Aug 2009 16:34:57 -0500 Original-Received: from serv108.segi.ulg.ac.be ([139.165.32.111]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1McQuS-0005vD-00 for ; Sat, 15 Aug 2009 23:35:32 +0200 Original-Received: (qmail 27975 invoked from network); 15 Aug 2009 23:34:24 +0200 Original-Received: from unknown (HELO tool.montefiore.ulg.ac.be) (u193113@[85.216.36.32]) (envelope-sender ) by serv108.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP for ; 15 Aug 2009 23:34:24 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68905 Archived-At: Hi - [Using Gnus v5.13 with Emacs 23.1.1 on Debian testing] I want to inactivate some groups by setting their level to 7, but I still want them to be listed in the *Group* buffer with 'L'. However, they do not appear, even though gnus-group-list-inactive-groups is t (the default). If the above indicates some misunderstanding on my part, please interrupt me right here. Otherwise I'll go on: In gnus-group-prepare-flat, I think the following code is broken: (when (gnus-group-prepare-logic group (and unread ; This group might be unchecked ;;;; For inactive groups, unread is nil, so ... (or (not (stringp regexp)) (string-match regexp group)) (<= (setq clevel (gnus-info-level info)) level) (>= clevel lowest) (cond ((functionp predicate) (funcall predicate info)) (predicate t) ; We list all groups? (t (or (if (eq unread t) ; Unactivated? ;;;; ... this condition is never reached: gnus-group-list-inactive-groups ; We list unactivated (> unread 0)) ; We list groups with unread articles I changed this code section into the following: (when (gnus-group-prepare-logic group (and (or unread gnus-group-list-inactive-groups) (or (not (stringp regexp)) (string-match regexp group)) (<= (setq clevel (gnus-info-level info)) level) (>= clevel lowest) (cond ((functionp predicate) (funcall predicate info)) (predicate t) ; We list all groups? (t (or (and (integerp unread) (> unread 0)) On a limited amount of tests, this code behaves as I would expect. Does this make sense, or am I misunderstanding what this code is supposed to do? Perhaps the real problem is elsewhere: The original code appears to make perfect sense if gnus-group-unread returns t for inactive groups, but for me it does not - it returns nil. Thanks, Justus