From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64222 Path: news.gmane.org!not-for-mail From: David Z Maze Newsgroups: gmane.emacs.gnus.general Subject: smtpmail.el: set-buffer-file-coding-system takes too many args Date: Wed, 03 Jan 2007 10:30:33 -0500 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1167838329 29785 80.91.229.12 (3 Jan 2007 15:32:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 Jan 2007 15:32:09 +0000 (UTC) Original-X-From: ding-owner+M12745@lists.math.uh.edu Wed Jan 03 16:32:06 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1H285w-00074s-28 for ding-account@gmane.org; Wed, 03 Jan 2007 16:32:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1H284y-0005Ks-Oq; Wed, 03 Jan 2007 09:31:00 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1H284v-0005KV-Md for ding@lists.math.uh.edu; Wed, 03 Jan 2007 09:30:57 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1H284p-0003ts-Hz for ding@lists.math.uh.edu; Wed, 03 Jan 2007 09:30:57 -0600 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1H284o-0001NE-00 for ; Wed, 03 Jan 2007 16:30:50 +0100 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l03FUm6P002439 for ; Wed, 3 Jan 2007 10:30:49 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l03FUaXo015759; Wed, 3 Jan 2007 10:30:39 -0500 (EST) Original-Received: from grumpy-fuzzball.mit.edu (GRUMPY-FUZZBALL.MIT.EDU [18.7.16.79]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l03FUYhQ004748; Wed, 3 Jan 2007 10:30:35 -0500 (EST) Original-To: ding@gnus.org User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (usg-unix-v) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-Spam-Flag: NO X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64222 Archived-At: --=-=-= I ran 'cvs update' after a long drought and suddenly couldn't send any mail! I tracked this down to a change in smtpmail.el that sets the coding system on outgoing mail buffers; it calls set-buffer-file-coding-system with four arguments, but my Emacs ("GNU Emacs 21.4.1 (sparc-sun-solaris2.10, X toolkit) of 2005-05-31 on maytag.mit.edu") only takes three. To make things work I needed the following: --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- smtpmail.el 27 Nov 2006 00:39:24 -0000 7.5 +++ smtpmail.el 3 Jan 2007 15:25:57 -0000 @@ -248,7 +248,7 @@ ;; buffer, otherwise any write-region invocations (e.g., in ;; mail-do-fcc below) will annoy with asking for a suitable ;; encoding. - (set-buffer-file-coding-system smtpmail-code-conv-from nil t) + (set-buffer-file-coding-system smtpmail-code-conv-from nil) (insert-buffer-substring mailbuf) (goto-char (point-max)) ;; require one newline at the end. @@ -394,7 +394,7 @@ (make-directory smtpmail-queue-dir t)) (with-current-buffer buffer-data (erase-buffer) - (set-buffer-file-coding-system smtpmail-code-conv-from nil t) + (set-buffer-file-coding-system smtpmail-code-conv-from nil) (insert-buffer-substring tembuf) (write-file file-data) (set-buffer buffer-elisp) --=-=-= Is the last arg necessary on some other Emacs? Is there some Gnus compatability shim that'll work here? Does its status in "contrib" affect things any? Thanks, --dzm --=-=-=--