From: David Z Maze <dmaze@MIT.EDU>
Subject: Re: Getting new mail really slow with nnml marks
Date: Wed, 17 Oct 2001 17:05:40 -0400 [thread overview]
Message-ID: <y68ofn6ugd7.fsf@indiana.mit.edu> (raw)
In-Reply-To: <ilu1yk2ujnq.fsf@barbar.josefsson.org> (Simon Josefsson's message of "Wed, 17 Oct 2001 21:54:33 +0200")
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Simon Josefsson <jas@extundo.com> writes:
SJ> Could you evaluate (nnml-marks-changed-p "nnml+foo:bar") to see if it
SJ> always return t?
Yes, it does. My theory is that this happens because
nnml-marks-changed-p tests whether the value gnus-gethash returns is
eq to the modtime returned by file-attributes; since they're
presumably not going to be the same object (I'd expect file-attributes
to return a new list every time), you want to test equality with
equal, rather than eq.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eq->equal patch to nnml.el --]
[-- Type: text/x-patch, Size: 739 bytes --]
Index: nnml.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnml.el,v
retrieving revision 6.29
diff -u -r6.29 nnml.el
--- nnml.el 2001/10/17 15:20:30 6.29
+++ nnml.el 2001/10/17 21:03:14
@@ -979,8 +979,8 @@
(nnmail-group-pathname group nnml-directory))))
(if (null (gnus-gethash file nnml-marks-modtime))
t ;; never looked at marks file, assume it has changed
- (not (eq (gnus-gethash file nnml-marks-modtime)
- (nth 5 (file-attributes file)))))))
+ (not (equal (gnus-gethash file nnml-marks-modtime)
+ (nth 5 (file-attributes file)))))))
(defun nnml-save-marks (group server)
(let ((file-name-coding-system nnmail-pathname-coding-system)
[-- Attachment #3: Type: text/plain, Size: 354 bytes --]
If I do this, then I get the whole updating-marks thing run at
startup, but not at all afterwards when I run 'g' (even if there is
new mail or I touch a .marks file). Is this expected?
--
David Maze dmaze@mit.edu http://www.mit.edu/~dmaze/
"Theoretical politics is interesting. Politicking should be illegal."
-- Abra Mitchell
next prev parent reply other threads:[~2001-10-17 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-17 15:16 David Z Maze
2001-10-17 16:16 ` Simon Josefsson
2001-10-17 16:54 ` David Z Maze
2001-10-17 17:14 ` David Z Maze
2001-10-17 17:28 ` Simon Josefsson
2001-10-17 17:44 ` David Z Maze
2001-10-17 19:54 ` Simon Josefsson
2001-10-17 21:05 ` David Z Maze [this message]
2001-10-18 19:34 ` Simon Josefsson
2001-10-18 21:38 ` David Z Maze
2001-10-20 9:53 ` Simon Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y68ofn6ugd7.fsf@indiana.mit.edu \
--to=dmaze@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).