From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/39379 Path: main.gmane.org!not-for-mail From: David Z Maze Newsgroups: gmane.emacs.gnus.general Subject: Re: Getting new mail really slow with nnml marks Date: Wed, 17 Oct 2001 17:05:40 -0400 Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1035175093 27547 80.91.224.250 (21 Oct 2002 04:38:13 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 04:38:13 +0000 (UTC) Return-Path: Original-Received: (qmail 28948 invoked from network); 17 Oct 2001 21:10:28 -0000 Original-Received: from malifon.math.uh.edu (mail@129.7.128.13) by mastaler.com with SMTP; 17 Oct 2001 21:10:28 -0000 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 15txwX-0004GF-00; Wed, 17 Oct 2001 16:09:37 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 17 Oct 2001 16:09:14 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id QAA02403 for ; Wed, 17 Oct 2001 16:09:01 -0500 (CDT) Original-Received: (qmail 28932 invoked by alias); 17 Oct 2001 21:09:17 -0000 Original-Received: (qmail 28927 invoked from network); 17 Oct 2001 21:09:17 -0000 Original-Received: from fort-point-station.mit.edu (18.72.0.53) by gnus.org with SMTP; 17 Oct 2001 21:09:17 -0000 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by fort-point-station.mit.edu (8.9.2/8.9.2) with ESMTP id RAA14230 for ; Wed, 17 Oct 2001 17:09:16 -0400 (EDT) Original-Received: from melbourne-city-street.mit.edu (MELBOURNE-CITY-STREET.MIT.EDU [18.7.21.86]) by grand-central-station.mit.edu (8.9.2/8.9.2) with ESMTP id RAA27898; Wed, 17 Oct 2001 17:09:16 -0400 (EDT) Original-Received: from indiana.mit.edu (INDIANA.MIT.EDU [18.18.1.138]) by melbourne-city-street.mit.edu (8.9.2/8.9.2) with ESMTP id RAA26565; Wed, 17 Oct 2001 17:05:40 -0400 (EDT) Original-To: ding@gnus.org In-Reply-To: (Simon Josefsson's message of "Wed, 17 Oct 2001 21:54:33 +0200") Original-Lines: 22 User-Agent: Gnus/5.090004 (Oort Gnus v0.04) XEmacs/21.4 (Artificial Intelligence) X-Attribution: DZM Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:39379 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:39379 --=-=-= Simon Josefsson writes: SJ> Could you evaluate (nnml-marks-changed-p "nnml+foo:bar") to see if it SJ> always return t? Yes, it does. My theory is that this happens because nnml-marks-changed-p tests whether the value gnus-gethash returns is eq to the modtime returned by file-attributes; since they're presumably not going to be the same object (I'd expect file-attributes to return a new list every time), you want to test equality with equal, rather than eq. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=nnml.el.diff Content-Description: eq->equal patch to nnml.el Index: nnml.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/nnml.el,v retrieving revision 6.29 diff -u -r6.29 nnml.el --- nnml.el 2001/10/17 15:20:30 6.29 +++ nnml.el 2001/10/17 21:03:14 @@ -979,8 +979,8 @@ (nnmail-group-pathname group nnml-directory)))) (if (null (gnus-gethash file nnml-marks-modtime)) t ;; never looked at marks file, assume it has changed - (not (eq (gnus-gethash file nnml-marks-modtime) - (nth 5 (file-attributes file))))))) + (not (equal (gnus-gethash file nnml-marks-modtime) + (nth 5 (file-attributes file))))))) (defun nnml-save-marks (group server) (let ((file-name-coding-system nnmail-pathname-coding-system) --=-=-= If I do this, then I get the whole updating-marks thing run at startup, but not at all afterwards when I run 'g' (even if there is new mail or I touch a .marks file). Is this expected? -- David Maze dmaze@mit.edu http://www.mit.edu/~dmaze/ "Theoretical politics is interesting. Politicking should be illegal." -- Abra Mitchell --=-=-=--