Re: PATCH: Unbreak `mailcap-mailcap-entry-passes-test'

[Michael Sperber <sperber@deinprogramm.de>]

Thanks for the quick action!

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> This is what I grasped of how mailcap.el does:
>
> What is passed to mailcap-mailcap-entry-passes-test is an entry
> of a mailcap file (user's or system's) like this:
>
> image/*; xv %s; test=test -n "$DISPLAY"
>
> This entry is parsed by mailcap-parse-mailcap into:
>
> ((viewer . "xv %s") (type . "image/*") (test . "test -n \"$DISPLAY\""))
>
> It is passed to mailcap-mailcap-entry-passes-test as an argument,
> and the result is added to mailcap-mime-data.  Where the result is
>
> ((viewer . "xv %s") (type . "image/*") (test . t))
>
> if $DISPLAY is not empty, otherwise:
>
> ((viewer . "xv %s") (type . "image/*") (test))

Right.  However, many typical mailcap entries will not have a test
clause.

> If your patch is applied, the `test' token will not be updated
> whatever $DISPLAY is.

I don't think so:

If there's a test clause present, the same code as before runs -
mutating the cdr as before.

If not, the function simply returns t, as documented.  (In that case,
there's nothing to mutate.)

-- 
Regards,
Mike