[BUG & FIX] `nnmail-get-new-mail' fetches too much

[BUG & FIX] `nnmail-get-new-mail' fetches too much

[Michael Sperber [Mr. Preprocessor]]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]


Here's a longstanding bug in Gnus, still present in Oort 0.02:

I have a group nnml:cvs with associated spool file
~/incoming/cvs.spool.  I also have a spool file called
~/incoming/freebsd-ports-cvs.spool with no associated group.

Getting new mail for nnml:cvs also slurps the freebsd-ports-cvs.spool
file into a non-existent nnml group because they share a suffix.

Bad juju.  Here's a fix.


[-- Attachment #2: Type: text/plain, Size: 202 bytes --]

2001-04-29  Michael Sperber [Mr. Preprocessor]  <sperber@informatik.uni-tuebingen.de>

	* nnmail.el (nnmail-get-new-mail): Make the generated predicate
	more strict to avoid reading in spurious spools.

[-- Attachment #3: Type: text/plain, Size: 422 bytes --]

--- lisp/nnmail.el.orig	Fri Apr 13 17:57:45 2001
+++ lisp/nnmail.el	Sun Apr 29 13:13:30 2001
@@ -1568,9 +1568,10 @@
 				  `(lambda (file)
 				     (string-match
 				      ,(concat
+					"^"
 					(regexp-quote (concat group suffix))
 					"$")
-				      file)))))))
+				      (file-name-nondirectory file))))))))
 	(when nnmail-fetched-sources
 	  (if (member source nnmail-fetched-sources)
 	      (setq source nil)

[-- Attachment #4: Type: text/plain, Size: 72 bytes --]



-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla

Re: [BUG & FIX] `nnmail-get-new-mail' fetches too much

[ShengHuo ZHU]

sperber@informatik.uni-tuebingen.de (Michael Sperber [Mr. Preprocessor]) writes:

> Here's a longstanding bug in Gnus, still present in Oort 0.02:
> 
> I have a group nnml:cvs with associated spool file
> ~/incoming/cvs.spool.  I also have a spool file called
> ~/incoming/freebsd-ports-cvs.spool with no associated group.
> 
> Getting new mail for nnml:cvs also slurps the freebsd-ports-cvs.spool
> file into a non-existent nnml group because they share a suffix.
> 
> Bad juju.  Here's a fix.
> 
> 2001-04-29  Michael Sperber [Mr. Preprocessor]  <sperber@informatik.uni-tuebingen.de>
> 
> 	* nnmail.el (nnmail-get-new-mail): Make the generated predicate
> 	more strict to avoid reading in spurious spools.
> --- lisp/nnmail.el.orig	Fri Apr 13 17:57:45 2001
> +++ lisp/nnmail.el	Sun Apr 29 13:13:30 2001
> @@ -1568,9 +1568,10 @@
>  				  `(lambda (file)
>  				     (string-match
>  				      ,(concat
> +					"^"
>  					(regexp-quote (concat group suffix))
>  					"$")
> -				      file)))))))
> +				      (file-name-nondirectory file))))))))
>  	(when nnmail-fetched-sources
>  	  (if (member source nnmail-fetched-sources)
>  	      (setq source nil)

Thanks for the report.  I fix it by using string-equal instead.

ShengHuo