From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/59317 Path: main.gmane.org!not-for-mail From: Ted Stern Newsgroups: gmane.emacs.gnus.general Subject: Re: bug in message.el, message-forward-make-body-plain Date: Wed, 01 Dec 2004 11:15:39 -0800 Organization: Cray Inc. Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: sea.gmane.org 1101929204 19459 80.91.229.6 (1 Dec 2004 19:26:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Dec 2004 19:26:44 +0000 (UTC) Original-X-From: ding-owner+M7857@lists.math.uh.edu Wed Dec 01 20:26:38 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CZa28-000375-00 for ; Wed, 01 Dec 2004 20:21:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1CZZxQ-0005rU-00; Wed, 01 Dec 2004 13:16:08 -0600 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1CZZxI-0005rM-00 for ding@lists.math.uh.edu; Wed, 01 Dec 2004 13:16:00 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1CZZxD-0003nv-VB for ding@lists.math.uh.edu; Wed, 01 Dec 2004 13:15:56 -0600 Original-Received: from main.gmane.org (main.gmane.org [80.91.229.2]) by justine.libertine.org (Postfix) with ESMTP id DE0CA3A003F for ; Wed, 1 Dec 2004 13:15:46 -0600 (CST) Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CZZx2-0003mc-00 for ; Wed, 01 Dec 2004 20:15:44 +0100 Original-Received: from ip-136-162-71-19.cray.com ([136.162.71.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Dec 2004 20:15:44 +0100 Original-Received: from stern+gnus by ip-136-162-71-19.cray.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Dec 2004 20:15:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Lines: 74 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: ip-136-162-71-19.cray.com User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) Cancel-Lock: sha1:Ent1lL/0CfZUB+abY1e+45naFtE= Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: main.gmane.org gmane.emacs.gnus.general:59317 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:59317 Thank you, Yamaoka-san, for your prompt response! Comments below. On 1 Dec 2004 at 00:19 PST, Katsumi Yamaoka wrote: >>>>>> In Ted Stern wrote: > >> message-forward ignores message-forward-ignored-headers when the prefix >> argument is non-nil. > >> To demonstrate: Change the value of message-forward-ignored-headers globally, > > [...] > >> Now enter any gnus group, and attempt to forward a message using >> C-u C-c C-f >> Instead of removing all but 4 or 5 relevant headers, nothing is changed. >> The same error occurs with >> M-4 C-c C-f > > I wrote the code for it, and then, I found a note when I was > going to write the ChangeLog file. > > 2002-07-27 Simon Josefsson > > * message.el (message-forward-make-body): Don't use > `message-forward-ignored-headers' when doing a "raw" followup (it > is important to preserve e.g. CTE). > > To forbid removing any headers will be overkill, however > message-forward-ignored-headers contains CTE, such an important > header, even now by default. I think excluding CTE from m-f-i-h > may not solve the problem. It is because m-f-i-h is a user > option and users can include any headers in it. Any ideas? The stated intent of Simon's change was to ignore message-forward-ignored-headers with raw followups, not with forwarding. So his change, which affects forwarding as well as followups, looks like an unintended bug, which apparently hasn't been objectionable enough to other users to be found before now. I guess I'm just picky. Plus, the bug I describe above takes effect in message-forward-make-body-plain, not message-forward-make-body. The cases Simon addressed should be possible to differentiate using the prefix argument, no? Specifically, if the prefix indicates inline arg=nil and (message-forward-as-mime=nil or message-forward-show-mml=nil) arg=1 arg=4 instead of rfc822 MIME. Or am I still missing something? C-c C-f runs the command gnus-summary-mail-forward which is an interactive compiled Lisp function in `gnus-msg'. (gnus-summary-mail-forward &optional ARG POST) Forward the current message(s) to another user. If process marks exist, forward all marked messages; if ARG is nil, see `message-forward-as-mime' and `message-forward-show-mml'; if ARG is 1, decode the message and forward directly inline; if ARG is 2, forward message as an rfc822 MIME section; if ARG is 3, decode message and forward as an rfc822 MIME section; if ARG is 4, forward message directly inline; otherwise, use flipped `message-forward-as-mime'. If POST, post instead of mail. For the `inline' alternatives, also see the variable `message-forward-ignored-headers'. Ted -- Ted Stern Applications Group Cray Inc. office: 206-701-2182 411 First Avenue South, Suite 600 cell: 206-383-1049 Seattle, WA 98104-2860 FAX: 206-701-2500 Frango ut patefaciam -- I break that I may reveal (The Paleontological Society motto, equally apropos for debugging)