Re: PATCH: Don't quote signature (was: Re: GNKSA and Gnus)

[Kim-Minh Kaplan <KimMinh.Kaplan@utopia.eunet.fr>]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Kim-Minh Kaplan <KimMinh.Kaplan@utopia.eunet.fr> writes:
> 
> > Gnus can put the quoted signature in the kill ring.
> 
> I don't think it's a good idea to push things to the kill ring without 
> user being aware of them.

Hmm, I get your point.  But if we don't do something, to cite a
signature one has to do:

    C-x b * A r t i c l e * RET M-> C-u C-r ^ - - SPC RET C-> M-w 
    C-x b RET C-y C-x C-x C-x r t > SPC RET

Ugly !  And it may be even worse if you have a different citation leader.

The attached code will provide `message-yank-cited-signatures' to
fetch the quoted signature.

> "Beware of bugs in the above code; I have only proved it correct,
> not tried it."                                    -- Donald Knuth

Well...  Beware of features in the code below: I have only tried it :-)

Kim-Minh.

[-- Attachment #2: Type: text/plain, Size: 2375 bytes --]

--- /usr/local/lib/xemacs/gnus/lisp/message.el	Tue Jan  6 07:48:40 1998
+++ /usr/tmp/message.el	Sun Jan 18 14:01:10 1998
@@ -814,6 +814,7 @@
 (defvar message-this-is-news nil)
 (defvar message-this-is-mail nil)
 (defvar message-draft-article nil)
+(defvar message-cite-signatures nil)
 
 ;; Byte-compiler warning
 (defvar gnus-active-hashtb)
@@ -1170,6 +1171,7 @@
   (define-key message-mode-map "\C-c\C-n" 'message-insert-newsgroups)
 
   (define-key message-mode-map "\C-c\C-y" 'message-yank-original)
+  (define-key message-mode-map "\C-cy" 'message-yank-cited-signatures)
   (define-key message-mode-map "\C-c\C-q" 'message-fill-yanked-message)
   (define-key message-mode-map "\C-c\C-w" 'message-insert-signature)
   (define-key message-mode-map "\C-c\C-r" 'message-caesar-buffer-body)
@@ -1689,24 +1691,43 @@
 
 (defun message-cite-original ()
   "Cite function in the standard Message manner."
+ (unless (local-variable-p 'message-cite-signatures (current-buffer))
+   (make-local-variable 'message-cite-signatures)
+   (setq message-cite-signatures nil))
   (let ((start (point))
+	(end (mark t))
+	sig-start
 	(functions
 	 (when message-indent-citation-function
 	   (if (listp message-indent-citation-function)
 	       message-indent-citation-function
 	     (list message-indent-citation-function)))))
+    (goto-char end)
+    (when (re-search-backward "^-- $" start t)
+      (setq sig-start (point-marker)))
     (goto-char start)
     (while functions
       (funcall (pop functions)))
     (when message-citation-line-function
       (unless (bolp)
 	(insert "\n"))
-      (funcall message-citation-line-function))))
+      (funcall message-citation-line-function))
+    (when sig-start
+      (setq message-cite-signatures
+	    (append message-cite-signatures
+		    (list (buffer-substring sig-start (mark t)))))
+      (delete-region sig-start (mark t))
+      (set-marker sig-start nil))))
 
 (defun message-insert-citation-line ()
   "Function that inserts a simple citation line."
   (when message-reply-headers
     (insert (mail-header-from message-reply-headers) " writes:\n\n")))
+
+(defun message-yank-cited-signatures ()
+  "Insert quoted signatures that where elided by the citation function."
+  (interactive)
+  (mapc 'insert message-cite-signatures))
 
 (defun message-position-on-field (header &rest afters)
   (let ((case-fold-search t))