From: Kim-Minh Kaplan <KimMinh.Kaplan@utopia.eunet.fr>
Cc: bugs@gnus.org (The Gnus Bugfixing Girls + Boys)
Subject: Re: Gnus fails to show some email messages
Date: 27 Mar 1998 21:59:23 +0100 [thread overview]
Message-ID: <yg47m5fu9xw.fsf@lombric.s-ip.eunet.fr> (raw)
In-Reply-To: Wes Hardaker's message of "26 Mar 1998 09:19:28 -0800"
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
>>>>> Wes Hardaker writes:
Wes> it looks like my problem is quite possibly related to
Wes> threading [...]
Wes> <v03102839b13db59cf4af@[128.120.226.137]>
[...]
Wes> <v03102839b13db59cf4af@[128.120.226.137]>
Definitly, this happens with references that contain duplicate ids.
This should fix it.
Kim-Minh.
[-- Attachment #2: Type: text/plain, Size: 1517 bytes --]
--- /usr/local/lib/xemacs/gnus/lisp/gnus-sum.el-5.6.3 Fri Mar 27 21:14:05 1998
+++ /usr/local/lib/xemacs/gnus/lisp/gnus-sum.el Fri Mar 27 21:44:35 1998
@@ -2960,7 +2960,8 @@
(let ((headers gnus-newsgroup-headers)
(deps gnus-newsgroup-dependencies)
header references generation relations
- cthread subject child end pthread relation new-child)
+ cthread subject child end pthread relation new-child
+ refs-uniq)
;; First we create an alist of generations/relations, where
;; generations is how much we trust the relation, and the relation
;; is parent/child.
@@ -2972,17 +2973,21 @@
(not (string= references "")))
(insert references)
(setq child (mail-header-id header)
+ refs-uniq (list child)
subject (mail-header-subject header))
(setq generation 0)
(while (search-backward ">" nil t)
(setq end (1+ (point)))
- (when (search-backward "<" nil t)
- (unless (string= (setq new-child (buffer-substring (point) end))
- child)
- (push (list (incf generation)
- child (setq child new-child)
- subject)
- relations))))
+ (when (and (search-backward "<" nil t)
+ (not (member (setq new-child
+ (buffer-substring (point) end))
+ refs-uniq)))
+ (push new-child refs-uniq)
+ (push (list (incf generation)
+ child (setq child new-child)
+ subject)
+ relations)))
(push (list (1+ generation) child nil subject) relations)
(erase-buffer)))
(kill-buffer (current-buffer)))
next prev parent reply other threads:[~1998-03-27 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-26 12:53 Hrvoje Niksic
1998-03-26 13:25 ` Stefanie Teufel
1998-03-26 14:57 ` Hrvoje Niksic
1998-03-26 15:24 ` Bruce Stephens
1998-03-26 15:29 ` Hrvoje Niksic
1998-03-26 15:58 ` Bruce Stephens
1998-03-26 15:32 ` Wes Hardaker
1998-03-26 17:05 ` Stefanie Teufel
1998-03-26 17:19 ` Wes Hardaker
1998-03-26 18:11 ` Stefanie Teufel
1998-03-26 21:24 ` Dan Christensen
1998-03-27 20:59 ` Kim-Minh Kaplan [this message]
1998-04-01 0:16 ` Eze Ogwuma
1998-04-01 17:23 ` Kim-Minh Kaplan
1998-04-01 20:44 ` Eze Ogwuma
1998-04-26 12:06 ` Gnus fails to show some email messages (and The horrible bug) Eze Ogwuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yg47m5fu9xw.fsf@lombric.s-ip.eunet.fr \
--to=kimminh.kaplan@utopia.eunet.fr \
--cc=bugs@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).