Gnus development mailing list
 help / color / mirror / Atom feed
From: Danny Siu <dsiu@adobe.com>
Subject: [Patch] Re: Patch for Summary thread tree using "%B"
Date: Wed, 25 Jul 2001 14:46:17 -0700	[thread overview]
Message-ID: <yj9bsm8u1g6.fsf@adobe.com> (raw)
In-Reply-To: <vxk3d7nmch8.fsf@cinnamon.vanillaknot.com> (Karl Kleinpaste's message of "Mon, 23 Jul 2001 19:50:43 -0400")

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]


If threading is turned off (T T in summary buffer) and %B is used in
g-s-line-format, an extra gnus-sum-thread-tree-single-leaf "\-> " would be
inserted.  I have attached a patch to fixed this.  It is a diff against the
latest (7/24/01 5pm) CVS.

Can someone who has write access commit the patch?

Thanks!
-- 
Danny Dick-Fung Siu        mailto:dsiu@adobe.com
Acrobat Engineering @ Adobe Systems Incorporated


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum-tree-patch.diff --]
[-- Type: text/x-patch, Size: 3015 bytes --]

diff -C5 orig/ChangeLog ./ChangeLog
*** orig/ChangeLog	Wed Jul 25 13:02:31 2001
--- ./ChangeLog	Wed Jul 25 12:57:56 2001
***************
*** 1,5 ****
--- 1,9 ----
+ 2001-07-25 12:54:00  Danny Siu <dsiu@adobe.com>
+ 	* gnus-sum.el (gnus-summary-prepare-threads): Shouldn't do tree
+ 	display (%B) for threads if threading is off.
+ 
  2001-07-24 13:00:00  ShengHuo ZHU  <zsh@cs.rochester.edu>
  
  	* gnus-sum.el (gnus-summary-display-arrow): Test fboundp.
  
  2001-07-24 12:00:00  ShengHuo ZHU  <zsh@cs.rochester.edu>
diff -C5 orig/gnus-sum.el ./gnus-sum.el
*** orig/gnus-sum.el	Tue Jul 24 15:15:07 2001
--- ./gnus-sum.el	Wed Jul 25 12:48:42 2001
***************
*** 4324,4346 ****
  	      ((string-match "(.+)" gnus-tmp-from)
  	       (substring gnus-tmp-from
  			  (1+ (match-beginning 0)) (1- (match-end 0))))
  	      (t gnus-tmp-from))
               gnus-tmp-thread-tree-header-string 
!              (if (zerop gnus-tmp-level)
!                  (if (cdar thread) 
!                      gnus-sum-thread-tree-root
!                    gnus-sum-thread-tree-single-indent)
!                (concat (apply 'concat
!                               (mapcar (lambda (item) 
!                                         (if (= item 1) 
                                              gnus-sum-thread-tree-vertical
!                                           gnus-sum-thread-tree-indent))
!                                       (cdr (reverse tree-stack))))
!                        (if (nth 1 thread) 
!                            gnus-sum-thread-tree-leaf-with-other
!                          gnus-sum-thread-tree-single-leaf))))
  
  	    (when (string= gnus-tmp-name "")
  	      (setq gnus-tmp-name gnus-tmp-from))
  	    (unless (numberp gnus-tmp-lines)
  	      (setq gnus-tmp-lines -1))
--- 4324,4349 ----
  	      ((string-match "(.+)" gnus-tmp-from)
  	       (substring gnus-tmp-from
  			  (1+ (match-beginning 0)) (1- (match-end 0))))
  	      (t gnus-tmp-from))
               gnus-tmp-thread-tree-header-string 
!              (cond 
!               ((not gnus-show-threads) "")
!                ((zerop gnus-tmp-level)
!                 (if (cdar thread) 
!                     gnus-sum-thread-tree-root
!                   gnus-sum-thread-tree-single-indent))
!                (t
!                 (concat (apply 'concat
!                                (mapcar (lambda (item) 
!                                          (if (= item 1) 
                                              gnus-sum-thread-tree-vertical
!                                            gnus-sum-thread-tree-indent))
!                                        (cdr (reverse tree-stack))))
!                         (if (nth 1 thread) 
!                             gnus-sum-thread-tree-leaf-with-other
!                           gnus-sum-thread-tree-single-leaf)))))
  
  	    (when (string= gnus-tmp-name "")
  	      (setq gnus-tmp-name gnus-tmp-from))
  	    (unless (numberp gnus-tmp-lines)
  	      (setq gnus-tmp-lines -1))

  parent reply	other threads:[~2001-07-25 21:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-23 23:50 Karl Kleinpaste
2001-07-24  5:06 ` ShengHuo ZHU
2001-07-24 17:37 ` Henrik Hansen
2001-07-24 19:32   ` Karl Kleinpaste
2001-07-24 19:55     ` Henrik Hansen
2001-07-25 21:46 ` Danny Siu [this message]
2001-07-25 22:19   ` [Patch] " ShengHuo ZHU
2001-07-27 22:35 ` Kai Großjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yj9bsm8u1g6.fsf@adobe.com \
    --to=dsiu@adobe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).