Re: cvslog

[Russ Allbery <rra@stanford.edu>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I think I've found what triggers it.  If I check something in (and I'm
> doing all this via pcl-cvs, if that matters), and I leave the commmit
> message blank, cvslog will infloop until I kill(1) it.

Aha.  Try this patch.

Index: cvslog
===================================================================
RCS file: /afs/ir/cvs/leland/CVSROOT/cvslog,v
retrieving revision 1.25
diff -u -r1.25 cvslog
--- cvslog      30 Dec 2001 22:34:34 -0000      1.25
+++ cvslog      2 Jan 2002 05:23:03 -0000
@@ -343,8 +343,8 @@
 sub parse_message {
     my $data = shift;
     my @message = <STDIN>;
-    shift @message while ($message[0] =~ /^\s*$/);
-    pop @message while ($message[-1] =~ /^\s*$/);
+    shift @message while (@message && $message[0] =~ /^\s*$/);
+    pop @message while (@message && $message[-1] =~ /^\s*$/);
     $$data{message}{text} = [ @message ];
 }

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>