Gnus development mailing list
 help / color / mirror / Atom feed
* spam.el simplified but wrong logic
@ 2004-04-27 10:39 Didier Verna
  2004-04-27 19:11 ` Johan Bockgård
  0 siblings, 1 reply; 2+ messages in thread
From: Didier Verna @ 2004-04-27 10:39 UTC (permalink / raw)



        Hi !

I think there's a bug introduced by:

2004-04-16  Teodor Zlatanov  <tzz@lifelogs.com>

	* spam.el (spam-summary-prepare-exit): simplified logic


on the following part of the code:

 ,----
|     (unless (and spam-move-spam-nonspam-groups-only
|                  (not (spam-group-spam-contents-p gnus-newsgroup-name)))
|       (gnus-message 5 "Marking spam as expired and moving it to %s"
|                     gnus-newsgroup-name)
|       (spam-mark-spam-as-expired-and-move-routine
|        (gnus-parameter-spam-process-destination gnus-newsgroup-name)))
`-----

The "logic" should rather be: 

(unless (and spam-move-spam-nonspam-groups-only
             (spam-group-spam-contents-p gnus-newsgroup-name))
   ...

right ?

I can apply a patch if you whish.

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: spam.el simplified but wrong logic
  2004-04-27 10:39 spam.el simplified but wrong logic Didier Verna
@ 2004-04-27 19:11 ` Johan Bockgård
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Bockgård @ 2004-04-27 19:11 UTC (permalink / raw)


Didier Verna <didier@lrde.epita.fr> writes:

> I think there's a bug introduced by:
>
> 2004-04-16  Teodor Zlatanov  <tzz@lifelogs.com>
>
> 	* spam.el (spam-summary-prepare-exit): simplified logic
> [...]

This was corrected several days ago.

-- 
Johan Bockgård



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-27 19:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-27 10:39 spam.el simplified but wrong logic Didier Verna
2004-04-27 19:11 ` Johan Bockgård

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).