From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/43237 Path: main.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: Katsumi Yamaoka's CVS update of gnus/lisp (73 files) Date: Fri, 22 Feb 2002 08:47:01 +0900 Organization: Emacsen advocacy group Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1035178362 16509 80.91.224.250 (21 Oct 2002 05:32:42 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 05:32:42 +0000 (UTC) Cc: ding@gnus.org Return-Path: Original-Received: (qmail 12909 invoked from network); 21 Feb 2002 23:48:57 -0000 Original-Received: from malifon.math.uh.edu (mail@129.7.128.13) by mastaler.com with SMTP; 21 Feb 2002 23:48:57 -0000 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 16e2vw-0005Dv-00; Thu, 21 Feb 2002 17:47:28 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 21 Feb 2002 17:47:27 -0600 (CST) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id RAA29646 for ; Thu, 21 Feb 2002 17:47:16 -0600 (CST) Original-Received: (qmail 12856 invoked by alias); 21 Feb 2002 23:47:12 -0000 Original-Received: (qmail 12850 invoked from network); 21 Feb 2002 23:47:11 -0000 Original-Received: from groundpoundrecords.com (207.228.244.150) by gnus.org with SMTP; 21 Feb 2002 23:47:11 -0000 Original-Received: from yamaoka@jpl.org by groundpoundrecords.com (localhost [127.0.0.1]) (8.11.1/8.11.1) id g1LNlAO03481 Fri, 22 Feb 2002 08:47:10 +0900 (JST) Original-To: Benjamin Rutt User-Agent: T-gnus/6.15.6 (based on Oort Gnus v0.06) XEmacs/21.5 (beta4) (bamboo) (sparc-sun-solaris2.6) WEMIKO/1.14.1 (=?ISO-2022-JP?B?GyRCNl9KXExTQ24bKEI=?=) CLIME/1.14.3 (=?ISO-2022-JP?B?GyRCO3swZkA+OH0bKEI=?=) APEL/10.3 X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:+MVN0VFL8NRMrqPUbsivqW6URW4= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:43237 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:43237 >>>>> In >>>>> Benjamin Rutt wrote: > OK. That wasn't obvious from your Changelog, since you mention > "spc+tab" which generally sounds like "all combinations of spaces and > tabs" being replaced with tab. Nope. I said literally SPACE and TAB. It can be replaced with single tab if it does not have the special meaning (e.g. a line commented out with leading ";; "). And we can save one byte in disk space. >> It is natural on the condition that the option `indent-tabs-mode' >> is t (by default). Could you see the actual Gnus source files? > OK, I cvs updated one file, and saved the old version first > (gnus-dired.el, a file I wrote not too long ago) to see the diffs. > What is the motivation for this change? I made sure of the differences between latest gnus-dired.el and old one (I've CVS checkd out it using -D '2 days ago'). I found I've removed traling spaces in seven lines and I've removed spaces from one line that there were only spaces in the line. I am using develock-mode[1] in lisp files, ChangeLog, etc. It does highlight such garbages loudly. [1] ftp://ftp.jpl.org/pub/elisp/develock.el.gz > When I wrote gnus-dired.el, the last thing I did before submitting it > for inclusion was M-x mark-whole-buffer and M-x indent-region, and > I've never customized any of the indention variables in > emacs-lisp-mode either. See: nnmaildir.el | 2124 ++++++++++++++++++++++++++--------------------------- and see what I've done on it. Maybe the author of this file has set the option `indent-tabs-mode' to nil. It makes source files fat needlessly. I must apologize to the author if there is the special sense, but I don't think so. I've modified it using Develock and advised commands as it has written under the default condition that `indent-tabs-mode' is t. > So, gnus-dired.el was originally indented > using emacs's default indentation in emacs-lisp-mode. Is there any > way I could have coded it differently to avoid requiring your > whitespace modification? If not, then I think you're going to have to > repeat the changes you made again and again as new code is submitted > using emacs-lisp-mode's default indentation rules. We only have to do just the right thing. We should never modify the basic options in the public space. We should take care that we don't leave garbages in the Gnus files. You don't have to use Develock, but it may help you to keep source files clean. -- Katsumi Yamaoka