From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/43093 Path: main.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: can't compile Gnus under Cygwin Date: Thu, 14 Feb 2002 10:12:02 +0900 Organization: Emacsen advocacy group Sender: owner-ding@hpc.uh.edu Message-ID: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1035178243 15728 80.91.224.250 (21 Oct 2002 05:30:43 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 05:30:43 +0000 (UTC) Cc: Takenobu Sugiyama Return-Path: Original-Received: (qmail 11382 invoked from network); 14 Feb 2002 03:55:59 -0000 Original-Received: from malifon.math.uh.edu (mail@129.7.128.13) by mastaler.com with SMTP; 14 Feb 2002 03:55:59 -0000 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 16bCzb-0005eY-00; Wed, 13 Feb 2002 21:55:31 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 13 Feb 2002 21:55:28 -0600 (CST) Original-Received: from epithumia.math.uh.edu (epithumia.math.uh.edu [129.7.128.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id VAA11264 for ; Wed, 13 Feb 2002 21:55:18 -0600 (CST) Original-Received: (from tibbs@localhost) by epithumia.math.uh.edu (8.11.2/8.11.1) id g1E3tFZ27686 for ding@hpc.uh.edu; Wed, 13 Feb 2002 21:55:15 -0600 Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id TAA10747 for ; Wed, 13 Feb 2002 19:12:17 -0600 (CST) Original-Received: (qmail 8862 invoked by alias); 14 Feb 2002 01:12:15 -0000 Original-Received: (qmail 8857 invoked from network); 14 Feb 2002 01:12:15 -0000 Original-Received: from groundpoundrecords.com (207.228.244.150) by gnus.org with SMTP; 14 Feb 2002 01:12:15 -0000 Original-Received: from yamaoka@jpl.org by groundpoundrecords.com (localhost [127.0.0.1]) (8.11.1/8.11.1) id g1E1C9Z12844 Thu, 14 Feb 2002 10:12:09 +0900 (JST) Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.1 (sparc-sun-solaris2.6) Cancel-Lock: sha1:MFLHZaDo48NX6+Gdj/4duIcxWsA= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:43093 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:43093 --=-=-= Hi, It is reported that someone can't compile Gnus under Cygwin. While compiling toplevel forms in file c:/home/gnus/lisp/earcon.el: !! File error (("Searching for program" "no such file or directory" "/bin/sh")) There is c:/cygwin/bin/sh.exe and it can be used as /bin/sh normally, but it won't be found at the compile time. Since I don't have Cygwin, I'm not sure what's happened. But it seems that the use of `shell-command-to-string' in the top level is harmful for compiling Gnus. Is the attached patch acceptable? If there's no objection, I'll commit it in Gnus CVS. :-) 2002-02-14 Katsumi Yamaoka * gnus-art.el (gnus-treat-display-xface): Don't use `shell-command-to-string' when compiling. (gnus-treat-display-grey-xface): Ditto. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gnus-art.el.diff --- gnus-art.el~ Wed Feb 13 02:20:52 2002 +++ gnus-art.el Thu Feb 14 01:09:29 2002 @@ -1070,7 +1070,8 @@ (put 'gnus-treat-overstrike 'highlight t) (defcustom gnus-treat-display-xface - (and (or (and (fboundp 'image-type-available-p) + (and (not noninteractive) + (or (and (fboundp 'image-type-available-p) (image-type-available-p 'xbm) (string-match "^0x" (shell-command-to-string "uncompface"))) (and (featurep 'xemacs) @@ -1086,7 +1087,8 @@ (put 'gnus-treat-display-xface 'highlight t) (defcustom gnus-treat-display-grey-xface - (and (string-match "^0x" (shell-command-to-string "uncompface")) + (and (not noninteractive) + (string-match "^0x" (shell-command-to-string "uncompface")) t) "Display grey X-Face headers. Valid values are nil, t." --=-=-=--