Gnus development mailing list
 help / color / mirror / Atom feed
* Messages Expire Even in Non-Expiry Group
@ 2003-05-15 19:54 Jake Colman
  2003-05-16  6:18 ` Kai Großjohann
  0 siblings, 1 reply; 5+ messages in thread
From: Jake Colman @ 2003-05-15 19:54 UTC (permalink / raw)



I have an email group that does not use expiry.  I copied emails from a group
that does use automatic expiration (the emails had the 'E' mark) into this
non-expiry group.  The messages happily stayed in this group and never
expired even though they had the 'E' mark - which is as I expected.  After
upgrading to 5.10.1 all those mails were deleted!  Is this supposed to have
worked this way?  I lost a whole LOT of mail this way!

-- 
Jake Colman                     

Principia Partners LLC                  Phone: (201) 209-2467
Harborside Financial Center               Fax: (201) 946-0320
902 Plaza Two                          E-mail: colman@ppllc.com
Jersey City, NJ 07311                  www.principiapartners.com



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Messages Expire Even in Non-Expiry Group
  2003-05-15 19:54 Messages Expire Even in Non-Expiry Group Jake Colman
@ 2003-05-16  6:18 ` Kai Großjohann
  2003-05-16  7:25   ` Katsumi Yamaoka
  0 siblings, 1 reply; 5+ messages in thread
From: Kai Großjohann @ 2003-05-16  6:18 UTC (permalink / raw)


Jake Colman <colman@ppllc.com> writes:

> I have an email group that does not use expiry.  I copied emails from a group
> that does use automatic expiration (the emails had the 'E' mark) into this
> non-expiry group.  The messages happily stayed in this group and never
> expired even though they had the 'E' mark - which is as I expected.  After
> upgrading to 5.10.1 all those mails were deleted!  Is this supposed to have
> worked this way?  I lost a whole LOT of mail this way!

Messages marked `E' are supposed to be expired, *except* if
nnmail-expiry-wait or nnmail-expiry-target say something else.

So, actually, Gnus seems to have had a bug before that was now
fixed...

It's a pity that you lost email, of course.
-- 
This line is not blank.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Messages Expire Even in Non-Expiry Group
  2003-05-16  6:18 ` Kai Großjohann
@ 2003-05-16  7:25   ` Katsumi Yamaoka
  2003-05-16 14:34     ` Jake Colman
  0 siblings, 1 reply; 5+ messages in thread
From: Katsumi Yamaoka @ 2003-05-16  7:25 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Hi,

>>>>> In <84k7crxvlw.fsf@lucy.is.informatik.uni-duisburg.de>
>>>>>	kai.grossjohann@gmx.net (Kai Großjohann) wrote:

> Messages marked `E' are supposed to be expired, *except* if
> nnmail-expiry-wait or nnmail-expiry-target say something else.

> So, actually, Gnus seems to have had a bug before that was now
> fixed...

I've made the following change in T-gnus (based on Gnus, using
SEMI and FLIM for MIME functions):

1999-01-18  Katsumi Yamaoka  <yamaoka@jpl.org>

	* gnus-sum.el (gnus-summary-move-article): Don't copy expirable
	marks if the destination group is not expirable.

Here's a patch for the recent Gnus.  How is it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 874 bytes --]

--- gnus-sum.el~	2003-05-13 22:58:57 +0000
+++ gnus-sum.el	2003-05-16 07:24:10 +0000
@@ -8793,6 +8793,9 @@
 		 (crosspost "Crosspost" "Crossposting")))
 	(copy-buf (save-excursion
 		    (nnheader-set-temp-buffer " *copy article*")))
+	(default-marks gnus-article-mark-lists)
+	(no-expire-marks (delete '(expirable . expire)
+				 (copy-sequence gnus-article-mark-lists)))
 	art-group to-method new-xref article to-groups)
     (unless (assq action names)
       (error "Unknown action %s" action))
@@ -8922,7 +8925,9 @@
 				       (list (cdr art-group)))))
 
 	    ;; See whether the article is to be put in the cache.
-	    (let ((marks gnus-article-mark-lists)
+	    (let ((marks (if (gnus-group-auto-expirable-p to-group)
+			     default-marks
+			   no-expire-marks))
 		  (to-article (cdr art-group)))
 
 	      ;; Enter the article into the cache in the new group,

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Messages Expire Even in Non-Expiry Group
  2003-05-16  7:25   ` Katsumi Yamaoka
@ 2003-05-16 14:34     ` Jake Colman
  2003-05-16 16:01       ` Katsumi Yamaoka
  0 siblings, 1 reply; 5+ messages in thread
From: Jake Colman @ 2003-05-16 14:34 UTC (permalink / raw)



Will this patch be applied to the version currently in CVS?  If I understood
correctly, it will remove the 'E' mark from messages that are copied from an
expirable group to one that is not expireable.  That would be great!

-- 
Jake Colman                     

Principia Partners LLC                  Phone: (201) 209-2467
Harborside Financial Center               Fax: (201) 946-0320
902 Plaza Two                          E-mail: colman@ppllc.com
Jersey City, NJ 07311                  www.principiapartners.com



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Messages Expire Even in Non-Expiry Group
  2003-05-16 14:34     ` Jake Colman
@ 2003-05-16 16:01       ` Katsumi Yamaoka
  0 siblings, 0 replies; 5+ messages in thread
From: Katsumi Yamaoka @ 2003-05-16 16:01 UTC (permalink / raw)
  Cc: ding

>>>>> In <763cjfc640.fsf@newjersey.ppllc.com> 
>>>>>	Jake Colman <colman@ppllc.com> wrote:

> Will this patch be applied to the version currently in CVS?  If I
> understood correctly, it will remove the 'E' mark from messages that
> are copied from an expirable group to one that is not expireable.
> That would be great!

Thanks for your response.  I've CVS committed it just now.
-- 



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-05-16 16:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-15 19:54 Messages Expire Even in Non-Expiry Group Jake Colman
2003-05-16  6:18 ` Kai Großjohann
2003-05-16  7:25   ` Katsumi Yamaoka
2003-05-16 14:34     ` Jake Colman
2003-05-16 16:01       ` Katsumi Yamaoka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).