Cannot subscribe or see nndrafts folder upon startup

Cannot subscribe or see nndrafts folder upon startup

[nyc4bos]

Hi,

I can't seem to be able to subscribe or see the nndrafts folder
upon starting Gnus.

When I start Gnus, I don't see the nndraft folder in the *Group*
buffer.

In order to see it, I have to

1. Type `A-A' `(gnus-group-list-active)'
2. Type `L' `(gnus-group-list-all-groups)'

The I see:

       *: nndraft:queue
       *: nndraft:drafts

I then click on Groups->Subscribe->Subscribe to a group

I can go into it and see drafts.

However, when I exit Gnus and go back in, the nndrafts:drafts does
NOT show up any more (and there are drafts in the folder).

I do I make the nndraft:drafts permenantly visible?

Thanks.

Re: Cannot subscribe or see nndrafts folder upon startup

[Lars Magne Ingebrigtsen]

nyc4bos@aol.com writes:

> However, when I exit Gnus and go back in, the nndrafts:drafts does
> NOT show up any more (and there are drafts in the folder).

I'm unable to reproduce this.  What does `G E' on the drafts group say?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Cannot subscribe or see nndrafts folder upon startup

[nyc4bos]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> nyc4bos@aol.com writes:
>
>> However, when I exit Gnus and go back in, the nndrafts:drafts does
>> NOT show up any more (and there are drafts in the folder).
>
> I'm unable to reproduce this.  What does `G E' on the drafts group say?

`G E' (`gnus-group-edit-group') says:

;;; Editing the group info for `nndraft:drafts'.
;; Type `C-c C-c' after you've finished editing.

("nndraft:drafts" 3
 ((1 . 11)
  (13 . 17)
  19 23
  (28 . 29))
 nil
 (nndraft "")
 ((gnus-dummy
   (gnus-draft-mode))))


For comparision, the nndraft:queue group (which, unlike the
nndraft:drafts has no currently queued messages awaiting) says:

;;; Editing the group info for `nndraft:queue'.
;; Type `C-c C-c' after you've finished editing.

("nndraft:queue" 1 nil nil
 (nndraft "")
 ((gnus-dummy
   (gnus-draft-mode))))

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

nyc4bos@aol.com wrote:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> nyc4bos@aol.com writes:
>>
>>> However, when I exit Gnus and go back in, the nndrafts:drafts does
>>> NOT show up any more (and there are drafts in the folder).
>>
>> I'm unable to reproduce this.  What does `G E' on the drafts group say?

Last night I realized that I'm unable to reproduce this, too, in
home Linux PC.  As for me it happens only in the office PC.  I
haven't found the cause yet, but we seem to have something wrong,
or Gnus might have something that leads new users to get this
problem (in the office PC I'm using Gnus for only two months, so
I'm a *new* user ;-).  I'll look into it further.

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Katsumi Yamaoka wrote:
> Last night I realized that I'm unable to reproduce this, too, in
> home Linux PC.  As for me it happens only in the office PC.

I found the cause of this problem at last.  This happens with at
least cygwin Emacs.  Don't you (nyc4bos@aol.com) use it?
In that platform,

(nth 1 (file-attributes nndraft-directory))

always returns 1 even though there are subdirectories in it.  So,
`nndraft-request-list' (i.e. `nnmh-request-list') doesn't recognize
it as a directory and draft messages in those subdirectories won't
be counted.  A temporary patch is attached.  What I should do next
is to learn what `subdirectoriesp' is for.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 386 bytes --]

--- nnmh.el~	2011-04-05 05:00:10.335000000 +0000
+++ nnmh.el	2011-06-29 11:25:31.625000000 +0000
@@ -210,7 +210,7 @@
 	(max 0)
 	min rdir num subdirectoriesp file)
     ;; Recurse down directories.
-    (setq subdirectoriesp (> (nth 1 (file-attributes dir)) 2))
+    (setq subdirectoriesp t)
     (dolist (rdir files)
       (if (or (not subdirectoriesp)
 	      (file-regular-p rdir))

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

Katsumi Yamaoka wrote:
> Katsumi Yamaoka wrote:
>> Last night I realized that I'm unable to reproduce this, too, in
>> home Linux PC.  As for me it happens only in the office PC.

> I found the cause of this problem at last.  This happens with at
> least cygwin Emacs.  Don't you (nyc4bos@aol.com) use it?
> In that platform,

> (nth 1 (file-attributes nndraft-directory))

> always returns 1 even though there are subdirectories in it.  So,
> `nndraft-request-list' (i.e. `nnmh-request-list') doesn't recognize
> it as a directory and draft messages in those subdirectories won't
> be counted.  A temporary patch is attached.  What I should do next
> is to learn what `subdirectoriesp' is for.

I've installed a fix.  But it is not enough to make the drafts
group behave as before.  That is, the articles count shown in
the group buffer will not be decreased after deleting draft
messages in the summary buffer unless I do `M-g' on the group
line.  I'll look into it...

Re: Cannot subscribe or see nndrafts folder upon startup

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I've installed a fix.

Great!

> But it is not enough to make the drafts group behave as before.  That
> is, the articles count shown in the group buffer will not be decreased
> after deleting draft messages in the summary buffer unless I do `M-g'
> on the group line.  I'll look into it...

Hm...  could the code I added to make it update the queue group
immediately be messing stuff up here?  I wouldn't think so...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Cannot subscribe or see nndrafts folder upon startup

[Richard Riley]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> I've installed a fix.
>
> Great!
>
>> But it is not enough to make the drafts group behave as before.  That
>> is, the articles count shown in the group buffer will not be decreased
>> after deleting draft messages in the summary buffer unless I do `M-g'
>> on the group line.  I'll look into it...
>
> Hm...  could the code I added to make it update the queue group
> immediately be messing stuff up here?  I wouldn't think so...

That stuff doesn't work properly - I posted details once or twice
before.  It only works in some instances. Easy to reproduce. New msg,
save to draft, look at groups, edit from drafts, send to queue, look at
groups, send from queue, look at groups.

Re: Cannot subscribe or see nndrafts folder upon startup

[Lars Magne Ingebrigtsen]

Richard Riley <rileyrg@googlemail.com> writes:

> That stuff doesn't work properly - I posted details once or twice
> before.  It only works in some instances. Easy to reproduce. New msg,
> save to draft, look at groups, edit from drafts, send to queue, look at
> groups, send from queue, look at groups.

The drafts group doesn't update until you hit `g', like other normal
groups.  It's somewhat difficult to have the group buffer update itself
when a message lands in the draft buffer -- it lands there by you just
saving the message you're composing.  And I don't want any Gnus stuff to
run off of `save-buffer-hook' or the like.

However, the drafts group could update itself when you delete a message
from it, for instance.  That would only be slightly inconsistent.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

Lars Magne Ingebrigtsen wrote:
> However, the drafts group could update itself when you delete a message
> from it, for instance.  That would only be slightly inconsistent.

When exiting a drafts' summary, `gnus-summary-prepare-exit-hook'
runs `gnus-draft-clear-marks' to mark all articles, that ACTIVE
asserts that they exist, as unread.  However, it doesn't care
deleted articles; IOW, ACTIVE doesn't know them at that time.
That is the reason articles count is not decreased after deleting
draft messages as before.  I've installed a fix.

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

Katsumi Yamaoka wrote:
> Lars Magne Ingebrigtsen wrote:
>> However, the drafts group could update itself when you delete a message
>> from it, for instance.  That would only be slightly inconsistent.

> When exiting a drafts' summary, `gnus-summary-prepare-exit-hook'
> runs `gnus-draft-clear-marks' to mark all articles, that ACTIVE
> asserts that they exist, as unread.  However, it doesn't care
> deleted articles; IOW, ACTIVE doesn't know them at that time.
> That is the reason articles count is not decreased after deleting
> draft messages as before.  I've installed a fix.

Er, the fix was incomplete.  It doesn't work properly if there're
sparse draft messages.  ACTIVE says only min. and max. articles,
however there will not necessarily be all articles successively
in the range.  Maybe newsgroup's read articles info, and also
ACTIVE, have to be updated when exiting the draft group.  I will
continue working on this...

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

Katsumi Yamaoka wrote:
> Katsumi Yamaoka wrote:
>> Lars Magne Ingebrigtsen wrote:
>>> However, the drafts group could update itself when you delete a message
>>> from it, for instance.  That would only be slightly inconsistent.

[...]
>> I've installed a fix.

> Er, the fix was incomplete.  It doesn't work properly if there're
> sparse draft messages.
[...]

I found the easiest way to fix it.  Installed.

Lars Magne Ingebrigtsen wrote:
> The drafts group doesn't update until you hit `g', like other normal
> groups.  It's somewhat difficult to have the group buffer update itself
> when a message lands in the draft buffer -- it lands there by you just
> saving the message you're composing.  And I don't want any Gnus stuff to
> run off of `save-buffer-hook' or the like.

I tried this.  A patch is below.  Not tested fully, though.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch for nndraft.el --]
[-- Type: text/x-patch, Size: 1104 bytes --]

--- nndraft.el~	2011-04-05 05:00:10.178750000 +0000
+++ nndraft.el	2011-07-01 10:31:26.218750000 +0000
@@ -161,6 +161,13 @@
      (message-headers-to-generate
       nndraft-required-headers message-draft-headers nil))))
 
+(defun nndraft-update-unread-articles (group)
+  "Return a function that updates unread articles of GROUP."
+  `(lambda nil
+     (with-current-buffer gnus-group-buffer
+       (let ((gnus-group-marked (list ,(concat "nndraft:" group))))
+	 (gnus-group-get-new-news-this-group nil t)))))
+
 (deffoo nndraft-request-associate-buffer (group)
   "Associate the current buffer with some article in the draft group."
   (nndraft-open-server "")
@@ -182,6 +189,10 @@
 		  'write-contents-hooks)))
       (gnus-make-local-hook hook)
       (add-hook hook 'nndraft-generate-headers nil t))
+    (let ((fn (nndraft-update-unread-articles group)))
+      (gnus-make-local-hook 'after-save-hook)
+      (add-hook 'after-save-hook fn nil t)
+      (message-add-action (caddr fn) 'exit 'postpone 'kill))
     article))
 
 (deffoo nndraft-request-group (group &optional server dont-check info)

Re: Cannot subscribe or see nndrafts folder upon startup

[nyc4bos]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Katsumi Yamaoka wrote:
>> Katsumi Yamaoka wrote:
>>> Lars Magne Ingebrigtsen wrote:
>>>> However, the drafts group could update itself when you delete a message
>>>> from it, for instance.  That would only be slightly inconsistent.
>
> [...]
>>> I've installed a fix.
>
>> Er, the fix was incomplete.  It doesn't work properly if there're
>> sparse draft messages.
> [...]
>
> I found the easiest way to fix it.  Installed.
>
> Lars Magne Ingebrigtsen wrote:
>> The drafts group doesn't update until you hit `g', like other normal
>> groups.  It's somewhat difficult to have the group buffer update itself
>> when a message lands in the draft buffer -- it lands there by you just
>> saving the message you're composing.  And I don't want any Gnus stuff to
>> run off of `save-buffer-hook' or the like.
>
> I tried this.  A patch is below.  Not tested fully, though.

I tried this patch (below).

I still have the original problem (nndraft:drafts group not listed
in *Group* buffer when starting Gnus).

Is that problem fixed (and waiting to be synced into bzr Gnus)?

Thanks.


>
>
> --- nndraft.el~	2011-04-05 05:00:10.178750000 +0000
> +++ nndraft.el	2011-07-01 10:31:26.218750000 +0000
> @@ -161,6 +161,13 @@
>       (message-headers-to-generate
>        nndraft-required-headers message-draft-headers nil))))
>  
> +(defun nndraft-update-unread-articles (group)
> +  "Return a function that updates unread articles of GROUP."
> +  `(lambda nil
> +     (with-current-buffer gnus-group-buffer
> +       (let ((gnus-group-marked (list ,(concat "nndraft:" group))))
> +	 (gnus-group-get-new-news-this-group nil t)))))
> +
>  (deffoo nndraft-request-associate-buffer (group)
>    "Associate the current buffer with some article in the draft group."
>    (nndraft-open-server "")
> @@ -182,6 +189,10 @@
>  		  'write-contents-hooks)))
>        (gnus-make-local-hook hook)
>        (add-hook hook 'nndraft-generate-headers nil t))
> +    (let ((fn (nndraft-update-unread-articles group)))
> +      (gnus-make-local-hook 'after-save-hook)
> +      (add-hook 'after-save-hook fn nil t)
> +      (message-add-action (caddr fn) 'exit 'postpone 'kill))
>      article))
>  
>  (deffoo nndraft-request-group (group &optional server dont-check info)

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

nyc4bos@aol.com wrote:
> I'm getting this error on:

> In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
>  of 2011-06-27 on 3249CTO
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (4.5) --no-opt --cflags
> -Ic:/build/include'

>>> In that platform,
>>
>>> (nth 1 (file-attributes nndraft-directory))
>>
>>> always returns 1
[...]
>> I've installed a fix.

> What was this fix?

Update your git copy, please.  Otherwise you can get it from:
http://article.gmane.org/gmane.emacs.gnus.cvs/11464

nyc4bos@aol.com wrote:
> I tried this patch (below).

> I still have the original problem (nndraft:drafts group not listed
> in *Group* buffer when starting Gnus).

> Is that problem fixed (and waiting to be synced into bzr Gnus)?

The patch I posted is for updating the number of unread articles
in the drafts group.  But that's still incomplete.  I'll install
a new version to the Gnus git repo after a while.

Re: Cannot subscribe or see nndrafts folder upon startup

[Katsumi Yamaoka]

Katsumi Yamaoka wrote:
> The patch I posted is for updating the number of unread articles
> in the drafts group.  But that's still incomplete.  I'll install
> a new version to the Gnus git repo after a while.

Installed in both the Gnus git trunk and the Emacs bzr trunk.

Re: Cannot subscribe or see nndrafts folder upon startup

[nyc4bos]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

Hi,
> Katsumi Yamaoka wrote:
>> The patch I posted is for updating the number of unread articles
>> in the drafts group.  But that's still incomplete.  I'll install
>> a new version to the Gnus git repo after a while.
>
> Installed in both the Gnus git trunk and the Emacs bzr trunk.

If it is nnmh.el, appears not to be synced up the the Emacs bzr
trunk as of yet.

Thanks.

Re: Cannot subscribe or see nndrafts folder upon startup

[nyc4bos]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Katsumi Yamaoka wrote:
>> Katsumi Yamaoka wrote:
>>> Last night I realized that I'm unable to reproduce this, too, in
>>> home Linux PC.  As for me it happens only in the office PC.
>
>> I found the cause of this problem at last.  This happens with at
>> least cygwin Emacs.  Don't you (nyc4bos@aol.com) use it?

I'm getting this error on:

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/build/include'

>> In that platform,
>
>> (nth 1 (file-attributes nndraft-directory))
>
>> always returns 1 even though there are subdirectories in it.  So,
>> `nndraft-request-list' (i.e. `nnmh-request-list') doesn't recognize
>> it as a directory and draft messages in those subdirectories won't
>> be counted.  A temporary patch is attached.  What I should do next
>> is to learn what `subdirectoriesp' is for.
>
> I've installed a fix.

What was this fix?

Thanks.

>                        But it is not enough to make the drafts
> group behave as before.  That is, the articles count shown in
> the group buffer will not be decreased after deleting draft
> messages in the summary buffer unless I do `M-g' on the group
> line.  I'll look into it...