Gnus development mailing list
 help / color / mirror / Atom feed
From: Linus Nordberg <linus@swox.se>
Subject: Re: {gnus|nnmail}-use-long-filename[s] beahviour changed
Date: 09 May 2000 10:56:10 +0200	[thread overview]
Message-ID: <yszk8h4w191.fsf@king.swox.se> (raw)
In-Reply-To: Lars Magne Ingebrigtsen's message of "21 Apr 2000 14:49:43 +0200"

Lars Magne Ingebrigtsen <larsi@gnus.org> wrote
21 Apr 2000 14:49:43 +0200:

   Linus Nordberg <linus@swox.se> writes:
   
   > i have both `gnus-use-long-file-name' and `nnmail-use-long-file-names'
   > set to nil, which prior to pgnus-0.99 made groups like "foo/bar" end
   > up in directory "foo/bar".  from pgnus-0.99 and on, "foo/bar" becomes
   > "foo_bar".
   
   What path names are affected in this manner?
   
I can't reproduce it with gnus-5.8.6 and an empty ~/.newsrc.eld, but
with my current ~/.newsrc.eld, articles for foo/bar ends up in the
directory ~/Mail/foo_bar.  This happens both when I move the article
manually using gnus-summary-move-article and when I let GNUS split
incoming articles.

It gets an article number that would fit nicely in ~/Mail/foo/bar, so
someone has obviously found its way there, but later decided to put
the article in the wrong directory.

nnmail-group-pathname has changed like this between pgnus-0.97 and
gnus-5.8.6:

*** 463,496 ****
    "Make pathname for GROUP."
    (concat
     (let ((dir (file-name-as-directory (expand-file-name dir))))
       (setq group (nnheader-translate-file-chars group))
       ;; If this directory exists, we use it directly.
!      (if (or nnmail-use-long-file-names
!            (file-directory-p (concat dir group)))
!        (concat dir group "/")
!        ;; If not, we translate dots into slashes.
!        (concat dir
!              (mm-encode-coding-string
!               (nnheader-replace-chars-in-string group ?. ?/)
!               nnmail-pathname-coding-system)
!              "/")))
     (or file "")))
--- 471,525 ----
    "Make pathname for GROUP."
    (concat
     (let ((dir (file-name-as-directory (expand-file-name dir))))
+      (setq group (nnheader-replace-duplicate-chars-in-string
+                 (nnheader-replace-chars-in-string group ?/ ?_)
+                 ?. ?_))
       (setq group (nnheader-translate-file-chars group))
       ;; If this directory exists, we use it directly.
!      (file-name-as-directory
!       (if (or nnmail-use-long-file-names
!             (file-directory-p (concat dir group)))
!         (expand-file-name group dir)
!       ;; If not, we translate dots into slashes.
!       (expand-file-name
!        (mm-encode-coding-string
!         (nnheader-replace-chars-in-string group ?. ?/)
!         nnmail-pathname-coding-system)
!        dir))))
     (or file "")))


Those three added lines, replacing `/' with `_' looks suspicious from
my point of view (though my lisp knowledge is poor, to say the least).

Or, maybe my ~/.newsrc.eld is corrupted in some subtle way?  Is there
a way to ``clean it up''?

--linus



  reply	other threads:[~2000-05-09  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-01-18  9:41 Linus Nordberg
2000-04-21 12:49 ` Lars Magne Ingebrigtsen
2000-05-09  8:56   ` Linus Nordberg [this message]
2000-05-09 17:04     ` Shenghuo ZHU
2000-05-10 10:52       ` Linus Nordberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yszk8h4w191.fsf@king.swox.se \
    --to=linus@swox.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).