incorrect behavior for the Sender field

[Hunter Kelly <retnuh@corona.pixar.com>]

I know that there has been a lot of discussion about whether a user
should be allowed to change the "Sender" field, but that is irrelevant
to the problem that I am having.

Red Gnus 0.74 (and earlier versions -- I am not sure how far back this
has been happening) generates a sender field when it shouldn't be.

The mail that I am sending out has headers that look like this:

Return-Path: retnuh@pixar.com
Received: from corona.pixar.com (corona.pixar.com [138.72.20.84]) by scam.XCF.Berkeley.EDU (8.7.5/8.7.3) with SMTP id SAA18597 for <retnuh@xcf.berkeley.edu>; Mon, 9 Dec 1996 18:01:46 -0800
Received: by corona.pixar.com (Smail3.1.29.1 #2)
        id m0vXHa6-00011dC; Mon, 9 Dec 96 18:06 PST
Sender: retnuh@pixar.com (Hunter Kelly)
Sender: retnuh@corona
To: retnuh@scam.XCF.Berkeley.EDU
Subject: test 7 methinks
From: Hunter Kelly <retnuh@corona.pixar.com>
Date: 09 Dec 1996 18:03:15 -0800
Message-ID: <yvt3exf40m4.fsf@corona.pixar.com>
Lines: 3


Notice that there are two lines that are "Sender".  I am not inserting
my own headers in any way.  The two occurances are causing messages to
get trashed in other mail readers, like Netscape 2.0.

I have no idea why it is generating the Sender field twice.  But the
second field is wrong, anyway.  Here are some relevant variables.

(message-make-sender)
"retnuh@corona"

(message-make-address)
"retnuh@corona.pixar.com"

(message-user-mail-address)
"retnuh@corona.pixar.com"

mail-host-address
"corona.pixar.com"


Now, in message-generate-headers, there is a block of code that looks
like this:

	(when (and from 
		   (not (message-check-element 'sender))
		   (not (string=
			 (downcase
			  (cadr (mail-extract-address-components from)))
			 (downcase secure-sender)))
		   (or (null sender)
		       (not 
			(string=
			 (downcase
			  (cadr (mail-extract-address-components sender)))
			 (downcase secure-sender)))))

I believe that the second string= is the wrong test.  It should be some form
of string match, because, as it has shown in my case, I am not
fiddling with the headers, but system-name does not return the FQDN.

This is really, really annoying, because certain people cannot read
mail I send them.  I think that either this needs to get fixed, so the
above behaves correctly, or Gnus should stop second-guessing the user
by insisting on a real Sender field.


Hunter