From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from homiemail-a20.g.dreamhost.com (caiajhbdccah.dreamhost.com [208.97.132.207]) by che.dreamhost.com (Postfix) with ESMTP id 1EB4DFE99 for ; Sun, 27 Mar 2011 06:04:37 -0700 (PDT) Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id C80887EC065 for ; Sun, 27 Mar 2011 05:50:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=the-brannons.com; h=from:to :subject:date:message-id; q=dns; s=the-brannons.com; b=YtSeBDeZY n4I8kvPdwhFCPefz+ep3DWwYz0hkurgtVIEyJt1A049hzW5uMftByD5DcE2A/Wdb jAUM+Yrt1XkTPPYzOJSYplvx3Ptgw30FAJMVrqXij9kYT/nj8ElHXAjV+ZaEb17N j3tl8VZk6fMx0IBupOiDYa0Tw0Q2nOm0ec= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=the-brannons.com; h=from :to:subject:date:message-id; s=the-brannons.com; bh=x8wCreagNUWI 77NUrezaO2W+34M=; b=qFtgpwHzhJDiAkzgYQW6pK6ZQhA8o9u7Z5DTjGGSFsbZ JZf1kxODHu4iSvseeBqFhxyasoDgPTqutE4H2wQIVbb9nnoZVDA19ZSn2tTrZwsO vJqOJlxw7+HwBVALXcWC1e1IvWpuDzkeWqGw5yL7C9zsy9QPAYCMNcvkQvq38j4= Received: from localhost (ip68-12-125-253.ok.ok.cox.net [68.12.125.253]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: chris@the-brannons.com) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPSA id 93DCF7EC060 for ; Sun, 27 Mar 2011 05:50:12 -0700 (PDT) From: Christopher Brannon To: edbrowse-dev@lists.the-brannons.com Date: Sun, 27 Mar 2011 12:50:11 +0000 Message-Id: <1301230211-31349-1-git-send-email-chris@the-brannons.com> X-Mailer: git-send-email 1.7.3.4 Subject: [Edbrowse-dev] [PATCH] Initialize some stack-allocated variables. X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2011 13:04:37 -0000 The uninitialized nogo variable was being used in the test of an if-statement. Code that assigns a value isn't guaranteed to execute before nogo is tested. I added some other initializations to runCommand as well, though these aren't strictly necessary. --- src/buffers.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/buffers.c b/src/buffers.c index 7710c2d..7382c13 100644 --- a/src/buffers.c +++ b/src/buffers.c @@ -3486,15 +3486,16 @@ readyUndo(void) bool runCommand(const char *line) { - int i, j, n, writeMode; - struct ebWindow *w; - void *ev; /* event variables */ - bool nogo, rc; + int i, j, n; + int writeMode = O_TRUNC; + struct ebWindow *w = NULL; + void *ev = NULL; /* event variables */ + bool nogo = true, rc = true; bool postSpace = false, didRange = false; char first; int cx = 0; /* numeric suffix as in s/x/y/3 or w2 */ int tagno; - const char *s; + const char *s = NULL; static char newline[MAXTTYLINE]; if(allocatedLine) { @@ -3637,7 +3638,6 @@ runCommand(const char *line) } first = *line; - writeMode = O_TRUNC; if(cmd == 'w' && first == '+') writeMode = O_APPEND, first = *++line; -- 1.7.3.4