From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 6B62077AAF for ; Tue, 24 Dec 2013 10:09:21 -0800 (PST) Received: by mail-wi0-f175.google.com with SMTP id hi5so12229617wib.14 for ; Tue, 24 Dec 2013 10:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=oF1ho7/3bh2fu2DlwClB41xOq+QjrbmkQ4V1fbw7WT4=; b=J70LrT+4PQe6Mm3mo5Fwq7LdF2ov0OI014kowvRkhbON7gmx8agP1hTapU7hMWUVEo O57gz2fIFnrvyS8FzPVC50S9iggOZ/OJCIo+B+m13zD3JlT5k68UeQLuiVRwGKpFCSBU i0TJUzHXxx5vAoWQ7dEQLDJ2FXm7AMm5QsdzY0LGXnwb3aswVAumxcn18gFnGmJ5giY2 RxYmPdXNpMIuKE2vR3z4Psl2/gwTMeb65ZP71nBBYy2pdzWo/KZ3euBqdgdqFU2uyzAD yA9NvPXD1YWv8nwnYZKgWKY8m7r17n7ObcuUjr59c8FdWlSdubHPplGO+u25lGljsPDQ pYbg== X-Received: by 10.194.6.161 with SMTP id c1mr319912wja.89.1387908554296; Tue, 24 Dec 2013 10:09:14 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id bc5sm37338196wib.4.2013.12.24.10.09.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Dec 2013 10:09:13 -0800 (PST) Date: Tue, 24 Dec 2013 18:09:11 +0000 From: Adam Thompson To: Karl Dahlke Message-ID: <20131224180911.GE18259@toaster.adamthompson.me.uk> References: <20131124120024.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131124120024.eklhad@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] this X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 18:09:21 -0000 On Tue, Dec 24, 2013 at 12:00:24PM -0500, Karl Dahlke wrote: > chris is right about this, > I use it as a variable several times in jsdom.c. > But we don't want to just > > ,s/this/t/g > > because this appears as an english word in quite a few comments. > So we just have to step through and replace with care. > Adam do you want to do this while you are in looking at other things, > or do you want me to replace and push? > Your call. Already done in the jsdom.cpp I sent. I used obj rather than this. This also depends on a change in eb.p as well, but I can send that once we're happy the c++ js* files are ok. I also had to alter several uses of class into objClass (not sure if you prefer objClass or obj_class, based on the function naming I chose the former, though I'd probably prefer the latter). I also think I know why you stopped using void * for js stuff, the massive amount of casting involved. Oh well. Cheers, Adam. PS: we probably want to condense some of the casting into a JSObject *obj = (JSObject *whatever) but I just went through the file with the intent of getting it to build. I can do cleanup once things are somewhere near working.