From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from QMTA11.westchester.pa.mail.comcast.net (qmta11.westchester.pa.mail.comcast.net [IPv6:2001:558:fe14:44:76:96:59:211]) by hurricane.the-brannons.com (Postfix) with ESMTP id 1E9077788B for ; Fri, 24 Jan 2014 04:13:35 -0800 (PST) Received: from omta14.westchester.pa.mail.comcast.net ([76.96.62.60]) by QMTA11.westchester.pa.mail.comcast.net with comcast id HnoA1n0041HzFnQ5BoDLta; Fri, 24 Jan 2014 12:13:20 +0000 Received: from eklhad ([107.5.36.150]) by omta14.westchester.pa.mail.comcast.net with comcast id HoDK1n0183EMmQj3aoDLql; Fri, 24 Jan 2014 12:13:20 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke User-Agent: edbrowse/3.4.10 Date: Fri, 24 Jan 2014 07:13:20 -0500 Message-ID: <20140024071320.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1390565600; bh=UP7VVUvZtdGOPd86wMKGGSkLoT3nkOwhn8+ZzphBFdQ=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=Lu5+/xt968CUAEhYESY3+5211B6nvG7P/RJIskEeXzW/pOuU4+RxC5WdNk8XuSkK5 qQz2Sv1rucFMKf5H7/8Dc2DiKI03Z4lOs/5DLnD5lBtqaREtpXfqmcqKeoIuAb+SKR iDc8IzFHnF0D+0TXUAKP/+l6WqUZkkNcbljzNy04/DnFw5NbeCDRQ+jj9nOlqz5hqe iq6wYuHpyu9c9JzaBVYPJMDEE4L3aakh5CZNUFUbr53ZKoi4SDLklxXmT/UOgkJElQ ol9TszkEyMdo8w/7rBsYdsD2qITK92gpo1kzTfVfypd1onjtRkV1vXfXbaN/bEvwQo L7U3hQDgBZrLQ== Subject: [Edbrowse-dev] my_ErrorReporter X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Karl Dahlke List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 12:13:35 -0000 Looks very much the same in Adam's latest as in mine. A small change, just to be safe, make the last line if(report) report->flags = 0; This function uses JS-smprintf and JS_free, and these are only used one other place in jsloc.c, and I don't get why the sprintf call doesn't need the js context, but the corresponding free call does. That just makes me nervous. No I don't think that's any of our bug problems so far, but it's something we should address before a stable release. And the funny thing is, JS_smprintf is almost pointless in the C++ world, just concatenate the strings together and C++ will manage everything. And in my_ErrorReporter we could even use cerr directly. So might be we don't even need the silly function, I'm just saying I don't quite understand it. As you see from this, I finally cloned your code. I plan to read through it first, then find / install moz 24, then build and play. Karl Dahlke