edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev]  [PATCH] Use the list class from the C++ STL,...
Date: Thu, 30 Jan 2014 16:58:53 -0500	[thread overview]
Message-ID: <20140030165853.eklhad@comcast.net> (raw)

> htmlTag should probably be a proper class,

I guess I figure when we use C++, for whatever reason, we should use its power.
And selfishly, it's a good way for me to learn it.
But I don't mean to create a lot of work for you either.

> all the char * members need to be replaced with string.

Need to? Really? Right away?
A good idea perhaps but might open up a can of worms.
Like name is assigned the string produced by htmlAttrVal() in format.c,
returning a c string of course,
and yes I suppose this would autocast itself into a c++ string,
but I wonder if there won't be a number of other cross file confusions here.

The cw->tags is a concern for sure.
Maybe could be void *, opaque pointer.
If I remember right I build the html stack and then just move it to cw->tags,
for that session, for the browsed file.
Then use cw->tags later as you interact with the browsed file.
Like filling out web forms, submitting, going to hyperlinks, etc,
all those actions being encapsulated in html.cpp.
Switch sessions and you get the tags for that session via cw->tags,
and so on.
But I should read through the code and make sure it's that simple.

Karl Dahlke

             reply	other threads:[~2014-01-30 21:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 21:58 Karl Dahlke [this message]
2014-01-30 22:18 ` Chris Brannon
2014-01-31 12:09 ` Adam Thompson
2014-01-31 12:35   ` Chris Brannon
  -- strict thread matches above, loose matches on Subject: below --
2014-01-31 18:37 Karl Dahlke
2014-01-31 18:48 ` Chris Brannon
2014-02-02 13:43 ` Adam Thompson
2014-01-31 13:02 Karl Dahlke
2014-01-31 17:33 ` Adam Thompson
2014-01-30 22:25 Karl Dahlke
2014-01-30 17:49 Karl Dahlke
2014-01-30 21:23 ` Chris Brannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140030165853.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).