From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qmta02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [IPv6:2001:558:fe14:43:76:96:62:24]) by hurricane.the-brannons.com (Postfix) with ESMTP id 9367B78013 for ; Sat, 1 Feb 2014 13:58:35 -0800 (PST) Received: from omta15.westchester.pa.mail.comcast.net ([76.96.62.87]) by qmta02.westchester.pa.mail.comcast.net with comcast id M9c41n0021swQuc519y8Ap; Sat, 01 Feb 2014 21:58:08 +0000 Received: from eklhad ([107.5.36.150]) by omta15.westchester.pa.mail.comcast.net with comcast id M9y81n00B3EMmQj3b9y8Ar; Sat, 01 Feb 2014 21:58:08 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke User-Agent: edbrowse/3.4.10 Date: Sat, 01 Feb 2014 16:58:09 -0500 Message-ID: <20140101165809.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1391291888; bh=ns8mpmcooyHvYk8qKH2zOvjh1BntQohcINcGgRbMnBY=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=s0k5C4vFOwXmFGL/dbOWq3DrweIWQn/KXEuNbzw+k0LpmGe0rQjBZxHb+1LDqbMRq 6serqrwgY4bd1FKLkIdrspFh7bkY3VBVQ03ckEZ/x/Mk5wM1qT0Wa91Tm37kOPFuD0 UFsL/N+XNGSefpQ5WpOoZH4ZaRgjdCN5BalL828u/UYg4VJ6CDXHqNxqimQsp0VyFT QFMUVqXO8+PgKvzjm77dL1EbsAFkzdg46XY1eT72KbRmEwSUiBHidHwHYl0pczNvIj 8h7zH1V4XEjRWu1I8lNCjfN8IALDKKoUqOS7TFhExezst9w0So7IRZRqigdqcVouSI K7mjkHpTf5T/w== Subject: [Edbrowse-dev] tags[] encapsulation X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Karl Dahlke List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2014 21:58:36 -0000 With Chris' patch in hand, he has passed it back to me, and I am working on it, but from a slighly different angle. My first push, now in the system, is strictly for encapsulation purposes. It moves the tags array into js state, so that I can, in the future, make it a c++ class if I wish. Instead of putting all the tags on htmlStack, then copying them over to the tags array, I might skip the middle step and put them straight into the tags array, which is already tied to the current window. In that case I would want tags to be the c++ construct, and now it can be, because it is part of that world that is only seen by the cpp files. Chris used the list class, but I'm thinking more about the vector class. Once the tags are built by the browse command, more tags are rarely if ever generated. Resizing doesn't happen. But random indexing into the array happens all the time. Every hyperlink, every field in a form, every click of a button, I jump to tags[n] where n is a number hidden behind that less than sign. So I think it would be perfect. It's not much different from Chris code, still an iterator to loop through, so mostly the same just easier random access. Well I'm not going to start that right away, I want to play with what I've done so far and make sure I didn't break anything. I also fixed a bug that was there before, that I ran into. The state field in jsrt for example, type i=mic You get question mark but the error is some meaningless error message, instead of what it should be, multiple options contain the string mic Course I thought I caused this bug with my work, but no, it was there before, so an easy one line fix. Karl Dahlke