From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qmta14.westchester.pa.mail.comcast.net (qmta14.westchester.pa.mail.comcast.net [IPv6:2001:558:fe14:44:76:96:59:212]) by hurricane.the-brannons.com (Postfix) with ESMTP id AE65A7845F for ; Sun, 9 Feb 2014 13:03:28 -0800 (PST) Received: from omta20.westchester.pa.mail.comcast.net ([76.96.62.71]) by qmta14.westchester.pa.mail.comcast.net with comcast id QM0c1n0011YDfWL5EM2q3N; Sun, 09 Feb 2014 21:02:50 +0000 Received: from eklhad ([107.5.36.150]) by omta20.westchester.pa.mail.comcast.net with comcast id QM2q1n00D3EMmQj3gM2qct; Sun, 09 Feb 2014 21:02:50 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke User-Agent: edbrowse/3.5.1 Date: Sun, 09 Feb 2014 16:02:51 -0500 Message-ID: <20140109160251.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1391979770; bh=HswDNGcbG3Q8Gu2PU73fpzPemBTgPzXhBevyb9pGy+8=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=oYdKUjcortHJUhnY95z/Zivf6wMNTFqkoxv7q3BcZL/NJWA+THOU+/IQyasqP5RjT aG0Jsm7SIaoB9T7eG0W4AOaiJxX5ebzNgK7sT/P5HaL1dMsE++0TxEEUAAC4YTBXJF VtrXAErUWbXA1xDU8fElm70hIERvKu4nvAHJHYCgWy7pJ9f+lPv3rNVGxglmXCvXHq 9w+piNY+IF9aM9/2PL2MrZ4wIbEaGIylJC/WI3H1vw6xSDgRei+m34dXYS9oObYWy1 1VXMRjUoa/cvF/YcCJ50awijpiTPB0Yq4TYUiei05wbh62gzdUqUnX4Hrza7f6C4hL wnfS79cntxCJg== Subject: [Edbrowse-dev] error legs first step X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Karl Dahlke List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Feb 2014 21:03:29 -0000 I wanted to ask you about this before I did anything. I think the first step in error legs is to allow for the possibility of cw->jss = null. It would become null if we encountered an error, and decided to free the java context, but still march on with the rest of edbrowse. That would among other things reclaim the memory used by that context. And I wouldn't even create the context if javascript was disabled or disabled for that site. This is something Adam asked about earlier. It would be just one line of code change in buffers.c line 4850. But I have to make sure things don't blow up if jss is null. So many functions now start out with AutoCompartment as their first line; before that I would put in if(!cw->jss) return; Or something like that. Anyways I would suggest this as the first step. Karl Dahlke