Re: [Edbrowse-dev] js progress update

[Adam Thompson <arthompson1990@gmail.com>]

On Tue, Jan 14, 2014 at 02:17:40PM -0800, Chris Brannon wrote:
> Adam Thompson <arthompson1990@gmail.com> writes:
> 
> > We also need to work out a good way of testing for memory leaks,
> > I was thinking of running under valgrind for extended periods of web browsing.
> 
> It's a good idea.  I found lots of memory leaks this way in the past,
> along with a couple memory corruption bugs.
> Browsing under valgrind is a little more sluggish, as one would expect,
> but it isn't terrible by any means.

Yeah, particularly if using a debug build of smjs.

I still haven't heard back about the debian package,
and am still no nearer figuring out what's going on there.
The segfault seems to be in something called as a consequence of the
JS_NewContext function, which doesn't break in any of the SpiderMonkey builds
I've done, even the ones with optimisations enabled and debugging disabled.

I've uncovered a very interesting js bug with this version of edbrowse though,
where it sometimes fails to initialise the standard classes for the jwin object.
I'm trying to work out exactly why this is the case,
however university assignments are reducing the speed of debugging at the moment.
It may be worth checking that I've always done the right thing regarding
setting jwin to the correct object and setting the correct compartment for the
js context.
Unfortunately it looks as if each new global object gets its own compartment
now and the only way I've managed to get the compartment to be switched
reliably is to switch at the start of each function which needs to use the global object.
This isn't particularly nice and needs cleaning up when we do the major rewrite.

Cheers,
Adam.