From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arthompson1990@gmail.com>
Received: from mail-bk0-x233.google.com (mail-bk0-x233.google.com
 [IPv6:2a00:1450:4008:c01::233])
 by hurricane.the-brannons.com (Postfix) with ESMTPS id E0DBD77891
 for <edbrowse-dev@lists.the-brannons.com>;
 Fri, 24 Jan 2014 06:58:53 -0800 (PST)
Received: by mail-bk0-f51.google.com with SMTP id w10so1195497bkz.24
 for <edbrowse-dev@lists.the-brannons.com>;
 Fri, 24 Jan 2014 06:58:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=l++tcKGIXR5IBs3kWspgpW7WstHmoDH8NxM6kRVo78c=;
 b=VD0B+y/P6LbwTeWKlOOBZ5FZpJ55+cXF2zUktssj3zG78lI4mtSCqw4ZIQ+0lPhyfu
 CoUP+dF1HXGRBL6GHqaW3XitCAX1iJUEk/V2gZAz8YZXG26feJGDe7u33fr8L9g+yUJ/
 txetVbbZbKXzT+SyhGtBQnaReFss4Empdz4UbMMEh2XKKkav/6M7CbZA2IJeOV+laVAV
 rqecLJmDFNr/bsZoD0XyTG6+OK+Mudn2yx+rkosKasrtozPrR5oLK2j3mXf0J4Aizpgd
 Y9H+N6Sjtu6KBkSRhy2AFH9iSgPfzSaTtIcJi2OXwhcXrVMET0k69FwgHBklH6WlyL9j
 DGLg==
X-Received: by 10.205.34.140 with SMTP id ss12mr257981bkb.121.1390575517552;
 Fri, 24 Jan 2014 06:58:37 -0800 (PST)
Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk.
 [2001:8b0:1142:9042::2])
 by mx.google.com with ESMTPSA id jc7sm793038bkb.0.2014.01.24.06.58.36
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Fri, 24 Jan 2014 06:58:36 -0800 (PST)
Date: Fri, 24 Jan 2014 14:58:33 +0000
From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Message-ID: <20140124145833.GE12450@toaster.adamthompson.me.uk>
References: <87lhy6qw9t.fsf@mushroom.PK5001Z>
 <20140124105929.GC12450@toaster.adamthompson.me.uk>
 <878uu5qx3y.fsf@mushroom.PK5001Z>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878uu5qx3y.fsf@mushroom.PK5001Z>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] garbage collection1
X-BeenThere: edbrowse-dev@lists.the-brannons.com
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Edbrowse Development List <edbrowse-dev.lists.the-brannons.com>
List-Unsubscribe: <http://lists.the-brannons.com/mailman/options/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=unsubscribe>
List-Archive: <http://lists.the-brannons.com/mailman/private/edbrowse-dev/>
List-Post: <mailto:edbrowse-dev@lists.the-brannons.com>
List-Help: <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=help>
List-Subscribe: <http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=subscribe>
X-List-Received-Date: Fri, 24 Jan 2014 14:58:54 -0000

On Fri, Jan 24, 2014 at 06:21:21AM -0800, Chris Brannon wrote:
> Adam Thompson <arthompson1990@gmail.com> writes:
> 
> >> We should not be passing unrooted jsval as the fourth
> >> argument to JS_DefineProperty as this can also lead to a crash.
> >
> > Yeah, I'm not sure how to work around this.
> 
> I am, and a patch is attached.  There may be other cases.  I can look through
> the code for them.  I fixed the one I noticed.

Ah, ok, I see what you mean. I've looked through and *hopefully* fixed a bunch of them.
I've definitely pushed the set of commits now (git push origin master)
so hoefully you can see them.

In addition I think we need to change the establish_property_* functions to take
JS::Handle and js::MutableHandle arguments.

Cheers,
Adam.