From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-x231.google.com (mail-bk0-x231.google.com [IPv6:2a00:1450:4008:c01::231]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 5098277891 for ; Fri, 24 Jan 2014 11:09:28 -0800 (PST) Received: by mail-bk0-f49.google.com with SMTP id v15so1374431bkz.36 for ; Fri, 24 Jan 2014 11:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=HjZevcT1GJCPqMBYQNO7ZnhPIcISbe7p3xrkFHlpkP0=; b=cb0Vtnka4Cr6xMBdkS6ATeb7nJH2A9srCd+NIH9x3wgCe7pC4YX/OK27khiTQWtk0L hZDOt+QWQVHwtM/se9gcqxUPJ90t0pN5APbt7DedWXUnE4zIj2j21H40T6CBwTl8lz0+ yUEvTdguwbnBzOUtSsyuIeRrYtGpx2rkQ5Nd/JtM4vJwRViVpW4x/AgmiLBCrg8g0j5L RzHfFEoUNw0kD2jyNil3nGZZovHXQGiJCXZpD+h7o+1GAl8ZlD2Rzu/6Q8eP2QhzviLZ FTbH5tDkwcG3eYklFbclj7mm1nLITtoSiSslcfHB4w/JZy4UfdTI1Lr/SgnMgDwhGKqb 2btg== X-Received: by 10.205.34.140 with SMTP id ss12mr1111584bkb.121.1390590551557; Fri, 24 Jan 2014 11:09:11 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id jc7sm1428949bkb.0.2014.01.24.11.09.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 Jan 2014 11:09:10 -0800 (PST) Date: Fri, 24 Jan 2014 19:08:59 +0000 From: Adam Thompson To: Karl Dahlke Message-ID: <20140124190859.GA10925@toaster.adamthompson.me.uk> References: <20140024071320.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140024071320.eklhad@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] my_ErrorReporter X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 19:09:28 -0000 On Fri, Jan 24, 2014 at 07:13:20AM -0500, Karl Dahlke wrote: > Looks very much the same in Adam's latest as in mine. > A small change, just to be safe, make the last line > > if(report) report->flags = 0; I've removed the JS_smprintf usage from jsloc.cpp and jsdom.cpp. > That just makes me nervous. What made me nervous about this was we were relying on something which isn't really publicly exposed in SpiderMonkey and they freely admit they change the internals (and public api) with no thought for backward compatability and very little notice. > No I don't think that's any of our bug problems so far, > but it's something we should address before a stable release. Agreed. > And the funny thing is, JS_smprintf is almost pointless in the C++ world, > just concatenate the strings together and C++ will manage everything. > And in my_ErrorReporter we could even use cerr directly. > So might be we don't even need the silly function, > I'm just saying I don't quite understand it. We don't, and it's gone as per my last set of commits. > As you see from this, I finally cloned your code. > I plan to read through it first, then find / install moz 24, > then build and play. Cool. I've just pushed the commits removing JS_smprintf and reformatting the code using ebindent. Cheers, Adam.