From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-x22c.google.com (mail-bk0-x22c.google.com [IPv6:2a00:1450:4008:c01::22c]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 6D65277892 for ; Sun, 26 Jan 2014 15:52:52 -0800 (PST) Received: by mail-bk0-f44.google.com with SMTP id mz12so2482819bkb.17 for ; Sun, 26 Jan 2014 15:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BGr6fLfNGRyEJfqQX7SjL/iCm2yH+jEdn1a1K7hhGkc=; b=QT1SX7vzOVARBw1aVpJ0+Cg54v4dsv6cs/uaMgyRGURJLR4IKJTW4jrCTTidxFHuwx CeiDCbBZaicYOq6J0e0VTkrJQpp6eBUr4gpr3Qr4fICXUsJqeCPDGMutX9YXjrMAb0D0 kh3KCLBeYsxONKem3rxA3qHKT3O9vzfI0uN9wmGoh6H4zzFtKbQJVk8Gd0aXfVSI+W/n f7971XehVOAMBadNi/mwbw8ULbIWj1yR60uIcR1KvwFChchto0q0L9kPLMQ883DrHcIP s2UpC+x55ELObqlx8hOw+5SeZwVnarjBOO/lit3dIRRlyMxQD0WsEyxtKT4yieI5Y6MG YIzQ== X-Received: by 10.204.122.1 with SMTP id j1mr17552617bkr.57.1390780351906; Sun, 26 Jan 2014 15:52:31 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id f3sm11531030bkk.4.2014.01.26.15.52.30 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 26 Jan 2014 15:52:31 -0800 (PST) Date: Sun, 26 Jan 2014 23:52:28 +0000 From: Adam Thompson To: Chris Brannon Message-ID: <20140126235228.GB17921@toaster.adamthompson.me.uk> References: <87ob2zof1u.fsf@mushroom.PK5001Z> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ob2zof1u.fsf@mushroom.PK5001Z> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] my very large patch X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 23:52:53 -0000 On Sat, Jan 25, 2014 at 02:46:37PM -0800, Chris Brannon wrote: > Ok, it is done. > I think it is too big to send to the list, so here's a link: > http://the-brannons.com/js.patch > The commit message should be a pretty good description of what I've > changed, so I won't rehash it here unless someone has questions. Ok, thanks. This is basically what I had in mind when I started doing this rewrite, but I didn't have enough time to completely remove the globals, hence the... interesting... rooting with JS_AddObjectRoot and friends. Will go through the code in more detail as I have more time. In addition, I think there's probably lots more cases where we're not correctly checking return values etc so I'll try and pick these up. Cheers, Adam.