From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-x22c.google.com (mail-bk0-x22c.google.com [IPv6:2a00:1450:4008:c01::22c]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 688DF77AFE for ; Mon, 27 Jan 2014 02:35:40 -0800 (PST) Received: by mail-bk0-f44.google.com with SMTP id mz12so2729420bkb.17 for ; Mon, 27 Jan 2014 02:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=VZ3xUdAJHQ3W6lQPvaaBk73wD1Cs3GRt8WMDA6ZTO/4=; b=CJnWzH1VL/mcuatlLX5jLZnh+djBCprsQPIqiyaY5QL5Pn3QPkmU054qB16EjUhEej /va6ee8UdAjXiAqYdwThjHWhnpaWwTk7aJwoU53BApUuTB9feXSsSBAgSGYB4wH8rOmb M1uYICtOJHrg7eiFeajG1cCeYI5IQS4ULNgko3rHAfHfZ+kf/fJF5xt1CU5RaZWiF7ed qa4RyDTM+x+DSrg/gEvI4zjJw7BlRUSegUtepOgF1cC735zA49RCexDg+P1026onc7zS iHt8pxKXvQWqqy4io8I5MNeNvCGGpqnLql2qlilpTcEs1Q8hLAkmq1cP0dI3KKZphJ8K ONCg== X-Received: by 10.205.77.131 with SMTP id zi3mr695956bkb.101.1390818917960; Mon, 27 Jan 2014 02:35:17 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id dt5sm13133963bkc.1.2014.01.27.02.35.16 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 27 Jan 2014 02:35:17 -0800 (PST) Date: Mon, 27 Jan 2014 10:35:14 +0000 From: Adam Thompson To: Chris Brannon Message-ID: <20140127103514.GD17921@toaster.adamthompson.me.uk> References: <87ob2zof1u.fsf@mushroom.PK5001Z> <20140126235228.GB17921@toaster.adamthompson.me.uk> <20140127004910.GC17921@toaster.adamthompson.me.uk> <87d2jenrqv.fsf@mushroom.PK5001Z> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d2jenrqv.fsf@mushroom.PK5001Z> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] my very large patch1 X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 10:35:41 -0000 On Sun, Jan 26, 2014 at 05:22:16PM -0800, Chris Brannon wrote: > Adam Thompson writes: > > > I'm also removing the jcx global and the jrt global. I'm going to remove the > > two explicit gc calls as well, > > Sounds good to me! I was just keeping jcx around for convenience, since > it's a little easier to type and to read with a screen reader than > cw->jss->jcx. But that's not really a good reason to keep it, IMHO. Yeah, and as Karl said, it also means we can remove the jMyContext function, which is useful I think. I'm also thinking of removing a couple of wrapper functions, like the ones which previously attempted to handle utf8 stuff with js as the new api gives no easy way of working out what mode the js engine is running in anyway, so we kind of need to hope everything's ok. Basically I think the rule with new SpiderMonkey is assume that the engine takes 1 byte per character strings unless using the jschar unicode functions (which is going to require much rewriting). Cheers, Adam.