From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arthompson1990@gmail.com>
Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com
 [IPv6:2a00:1450:400c:c00::22c])
 by hurricane.the-brannons.com (Postfix) with ESMTPS id 24AE877D3E
 for <Edbrowse-dev@lists.the-brannons.com>;
 Thu, 30 Jan 2014 02:33:51 -0800 (PST)
Received: by mail-wg0-f44.google.com with SMTP id l18so5873296wgh.35
 for <Edbrowse-dev@lists.the-brannons.com>;
 Thu, 30 Jan 2014 02:33:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=ump3nQM/B6hc0B7+u4rzUAKHeM82B9J1W3iQeGIhoFo=;
 b=Or6gP6hAca1Fg9FG4JTWgDqnvJBJwUV0yd+E39NSGfhy71LxjF6TvHT3qQXM8tmvD5
 x9B6zSWkyB+TnG8ZdxA0gBd0DzaJsh26c/RRwgVHLrPdCDipjCDTp2VuZoZrh5CIQAxH
 4HbkbykDyQNFVj4Ukcj97IPUuzIH+Prq8MKRa8F3eRsQkiNVehdd9qYh5NHYyPfLLGXw
 YOi2jiQgsWzxMzJhKBxzvPu87aZ7XSbfj1odSnFe/EH3caGF9QbvjmqyjNQL4q+WK3KQ
 sTJM2pZwd1jMrKAotIXNAJuE1QK/YW5XRrRC7Wqi+TG5rRBE5dlbUBlDY+rA0VVNgpWL
 yU3Q==
X-Received: by 10.194.61.84 with SMTP id n20mr657509wjr.61.1391078005716;
 Thu, 30 Jan 2014 02:33:25 -0800 (PST)
Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk.
 [2001:8b0:1142:9042::2])
 by mx.google.com with ESMTPSA id ev4sm11659294wib.1.2014.01.30.02.33.24
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Thu, 30 Jan 2014 02:33:25 -0800 (PST)
Date: Thu, 30 Jan 2014 10:33:22 +0000
From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Message-ID: <20140130103322.GK7404@toaster.adamthompson.me.uk>
References: <alpine.LNX.2.03.1401290701220.8817@ftml.net>
 <20140129134409.GG7404@toaster.adamthompson.me.uk>
 <871tzqmojl.fsf@mushroom.PK5001Z>
 <alpine.LNX.2.03.1401291755240.22740@ftml.net>
 <87wqhil5jv.fsf@mushroom.PK5001Z>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wqhil5jv.fsf@mushroom.PK5001Z>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Edbrowse Development <Edbrowse-dev@lists.the-brannons.com>
Subject: Re: [Edbrowse-dev] compiling edbrowse with js24
X-BeenThere: edbrowse-dev@lists.the-brannons.com
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Edbrowse Development List <edbrowse-dev.lists.the-brannons.com>
List-Unsubscribe: <http://lists.the-brannons.com/mailman/options/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=unsubscribe>
List-Archive: <http://lists.the-brannons.com/mailman/private/edbrowse-dev/>
List-Post: <mailto:edbrowse-dev@lists.the-brannons.com>
List-Help: <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=help>
List-Subscribe: <http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 10:33:51 -0000

On Wed, Jan 29, 2014 at 03:41:24PM -0800, Chris Brannon wrote:
> Chuck Hallenbeck <chuckh@ftml.net> writes:
> 
> So don't modify the makefile.  I'd suggest a script like this one:
> 
> #!/bin/sh
> # ebmake, build edbrowse
> # Expects to be run from the root of the edbrowse tree,
> 
> LDFLAGS=-L/usr/local/lib make JS_CXXFLAGS=/usr/local/include/mozjs-24
> # End of script.
> 
> This is sort of how we do things when packaging for distributions.
> Typically, we don't write patches against the makefile, because they're
> fragile.  It's better to set variables or flip configure switches.
> Since edbrowse doesn't have a configure script, we end up setting
> environment variables, or in the case of JS_CXXFLAGS, "make" variables.
> Don't make the mistake of using JS_CXXFLAGS as an environment variable,
> because make will override it.

Good point.

> Instead, it needs to be passed after the make command, so make will do
> the substitution:
> make JS_CXXFLAGS=whatever

You may also want to add -Wno-invalid-offsetof to the JS_CXXFLAGS variable to
prevent *lots* of warnings about stuff in various mozjs-24 headers.

Cheers,
Adam.