Re: [Edbrowse-dev] [PATCH] Use the list class from the C++ STL,...

[Adam Thompson <arthompson1990@gmail.com>]

On Fri, Jan 31, 2014 at 01:37:31PM -0500, Karl Dahlke wrote:
> > my gcc gives me a bunch of warnings in url.c about using int and size_t
> 
> Mine doesn't, which is odd, but sure make any changes you like.
> 

Which gcc version are you using?

> > Yeah, but then we've still got the cw->tags array to worry about.
> 
> Shouldn't be a problem, if we move tags into jsstate,
> thus cw->jss->tags, as I wrote Chris off-line.
> The only reference elsewhere is some freeTags call in buffers.c,
> but we could just pass cw->jss in that case.
> Then it's all encapsulated in html.cpp, and should be easy.

Yep, sounds good.

> 
> I'd thought about the link list for the lines in a file,
> but it would be a lot of rewrite.
> Wouldn't help me much, I only have 2 gig ram anyways,
> and might even reduce the sizes of files I can edit.
> At this level it is a bit like politics,
> anything we do here will help some people and hurt others.

Perhaps, though I'd say having a hard limit on how long you can run edbrowse
for (due to the lack of line index reuse) is something which should be fixed.
Without using a linked list, I really can't think of a nice way round the issue
without shifting all the lines down to fill the gaps in the array (possibly
once the indices are all gone). This sounds a bit nasty though and I'm not sure
how large the implications of such swapping would be.

Cheers,
Adam.