From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 3149377892 for ; Sun, 2 Feb 2014 05:43:43 -0800 (PST) Received: by mail-we0-f181.google.com with SMTP id w61so1235944wes.12 for ; Sun, 02 Feb 2014 05:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=5QFRnyvjDeTpGL8551wztDV3/axxEgxztF2mQ7SeU/c=; b=vh+0g6zblzceHNb5RM0fxsb8czx1XCMH3OMet8qfx1LUVWHgiP+8utrJrFsNmSLoHS 4vRicO+86NQHeR2/CjQuGlzrVUjEItq2gy8bRfffK1lu8vh6cK2F3kUysOZWn++8qv68 JLguDvjMV5u6NfmT7rdpsVUssOD0lV30KlS8jLoGvESM+ejsRhP6G56UB2ugXKyrEko7 m+DTDs2UOvNdFxfPCWp73zZR1Nv1ZfFPCnSS5IQkUyd6Vh42/PReiB8ymJQ6FjV7StmK ZQKhbfmkBcAFCccxVLryXcBIzfWTW5VJD5AkHNnMvBEgfVCq4SMVDH++RplxAUYKO4Za 9idQ== X-Received: by 10.180.165.199 with SMTP id za7mr5419430wib.49.1391348594564; Sun, 02 Feb 2014 05:43:14 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id eo4sm16183656wib.9.2014.02.02.05.43.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 02 Feb 2014 05:43:13 -0800 (PST) Date: Sun, 2 Feb 2014 13:43:11 +0000 From: Adam Thompson To: Karl Dahlke Message-ID: <20140202134311.GC32200@toaster.adamthompson.me.uk> References: <20140031133731.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140031133731.eklhad@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] [PATCH] Use the list class from the C++ STL,... X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Feb 2014 13:43:43 -0000 On Fri, Jan 31, 2014 at 01:37:31PM -0500, Karl Dahlke wrote: > > my gcc gives me a bunch of warnings in url.c about using int and size_t > > Mine doesn't, which is odd, but sure make any changes you like. > Which gcc version are you using? > > Yeah, but then we've still got the cw->tags array to worry about. > > Shouldn't be a problem, if we move tags into jsstate, > thus cw->jss->tags, as I wrote Chris off-line. > The only reference elsewhere is some freeTags call in buffers.c, > but we could just pass cw->jss in that case. > Then it's all encapsulated in html.cpp, and should be easy. Yep, sounds good. > > I'd thought about the link list for the lines in a file, > but it would be a lot of rewrite. > Wouldn't help me much, I only have 2 gig ram anyways, > and might even reduce the sizes of files I can edit. > At this level it is a bit like politics, > anything we do here will help some people and hurt others. Perhaps, though I'd say having a hard limit on how long you can run edbrowse for (due to the lack of line index reuse) is something which should be fixed. Without using a linked list, I really can't think of a nice way round the issue without shifting all the lines down to fill the gaps in the array (possibly once the indices are all gone). This sounds a bit nasty though and I'm not sure how large the implications of such swapping would be. Cheers, Adam.