From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] suggest increasing the size argument to JS_NewRuntime
Date: Fri, 7 Feb 2014 08:13:10 +0000 [thread overview]
Message-ID: <20140207081310.GC3978@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <878utnhim0.fsf@mushroom.PK5001Z>
On Thu, Feb 06, 2014 at 04:27:51PM -0800, Chris Brannon wrote:
> From what I can tell, the remaining segfaults all seem to be caused by
> out-of-memory errors in JS. As an aside, with debug level 2 or greater,
> edbrowse will print "out of memory" before it crashes.
> I've increased the size argument to JS_NewRuntime locally, and it
> helps. I'd suggest bumping it from 4 megabytes to at least 16 or 32.
> Any objections?
Not really, should this be configurable?
> Also, I pushed the patch that we discussed earlier today.
Ok, will build and test today.
Cheers,
Adam.
next prev parent reply other threads:[~2014-02-07 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 0:27 Chris Brannon
2014-02-07 8:13 ` Adam Thompson [this message]
2014-02-07 6:30 Karl Dahlke
2014-02-07 8:26 ` Adam Thompson
2014-02-07 13:13 ` Chris Brannon
2014-02-07 14:26 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207081310.GC3978@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=chris@the-brannons.com \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).