From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arthompson1990@gmail.com>
Received: from mail-ea0-x235.google.com (mail-ea0-x235.google.com
 [IPv6:2a00:1450:4013:c01::235])
 by hurricane.the-brannons.com (Postfix) with ESMTPS id 388977847A
 for <Edbrowse-dev@lists.the-brannons.com>;
 Tue, 11 Feb 2014 07:42:12 -0800 (PST)
Received: by mail-ea0-f181.google.com with SMTP id k10so1565084eaj.12
 for <Edbrowse-dev@lists.the-brannons.com>;
 Tue, 11 Feb 2014 07:41:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=G886FQtim9bSzDTQw31aA3ngZUTDnD5G982Ewa4KGfk=;
 b=ZD7cw2I04xHWbNzygC8kRpBp3p6VnTcdz23ge0oBzlmq+NGdrO21yxM6QMMT6k6Kit
 7IlDQ/S2kA0QVfw3tMWG2zl6PvmheURmPmWtu3B9T0m/MuGMSe0c8Ig1gClwIjcWwv24
 o3f2vCKGYyjLG1hD+gihHLmvWDAdLfWzFZXeDk/aZ7F3mk5A0wLcuhXxC761OjdfNCql
 DnI4S59VGprOpvB0Xnh7ThdZq30G1uUVN0K8Vr9yph3M6o3i1EkEl1DnB7yWbwpBXcPX
 s/QodUoM63OUX5lUvUadFA5dza7+8gv0ti1Z/h/QyB5fhP3t4PhecYabYg/pN+Cx2Blv
 pIhg==
X-Received: by 10.14.216.193 with SMTP id g41mr45412010eep.13.1392133287865;
 Tue, 11 Feb 2014 07:41:27 -0800 (PST)
Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk.
 [2001:8b0:1142:9042::2])
 by mx.google.com with ESMTPSA id j42sm69366958eep.21.2014.02.11.07.41.25
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Tue, 11 Feb 2014 07:41:26 -0800 (PST)
Date: Tue, 11 Feb 2014 15:41:23 +0000
From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Message-ID: <20140211154123.GP11542@toaster.adamthompson.me.uk>
References: <20140111065522.eklhad@comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140111065522.eklhad@comcast.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] AutoCompartment other window
X-BeenThere: edbrowse-dev@lists.the-brannons.com
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Edbrowse Development List <edbrowse-dev.lists.the-brannons.com>
List-Unsubscribe: <http://lists.the-brannons.com/mailman/options/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=unsubscribe>
List-Archive: <http://lists.the-brannons.com/mailman/private/edbrowse-dev/>
List-Post: <mailto:edbrowse-dev@lists.the-brannons.com>
List-Help: <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=help>
List-Subscribe: <http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=subscribe>
X-List-Received-Date: Tue, 11 Feb 2014 15:42:12 -0000

On Tue, Feb 11, 2014 at 06:55:22AM -0500, Karl Dahlke wrote:
> A question for you in jsdom.cpp function domLink().
> This line
> 
>         JS::RootedObject owner_root(cw->jss->jcx, owner);
> 
> Then you use owner_root instead of owner thereafter.
> Is this necessary?
> owner is safely rooted on the heap and isn't going to go anywhere.
> We could just use owner throughout and it would be much clearer.

That's from when the html parser wasn't js-aware,
I've just pushed a change rectifying this (removing owner_root).

Cheers,
Adam.