From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x234.google.com (mail-wg0-x234.google.com [IPv6:2a00:1450:400c:c00::234]) by hurricane.the-brannons.com (Postfix) with ESMTPS id ADE057849F for ; Wed, 19 Feb 2014 06:13:35 -0800 (PST) Received: by mail-wg0-f52.google.com with SMTP id b13so373396wgh.19 for ; Wed, 19 Feb 2014 06:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pNO5jlTruaduloYr43o7jzvWeqsO6qvGhwH80U8No90=; b=SVi3fa/pzu6al6dLTq0dC150vmoBt5AdwdOFfcjNp74eQVAFqhXsMXrhY97tWJHfum AGvoPL/hPDFLu0e+9v1W16wyD2eqb+6j4uq4gkJXDgGKa4cuS/eZuSy2gOvpfVGhodiM V7XDncZoJjBYrvE4H//gj9YYMvce+23dlpy507KC/YJjPjMOZAdRe8hqItPjXOc9+sLS /bNSU5naZtHfHpZ6Io2Y+h7g4RT+9ujMlemHwi2IruEk7j2xLkjUr39jctSnaDdl9XFV Pw5Pea9JmNp7FMdEWomqddmVn72shAuiuYjsgw5STYhB3a7OTBn3NFT0doX0scWc04kT qhiw== X-Received: by 10.180.73.103 with SMTP id k7mr1772480wiv.24.1392819160538; Wed, 19 Feb 2014 06:12:40 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id ff9sm52200644wib.11.2014.02.19.06.12.39 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Feb 2014 06:12:39 -0800 (PST) Date: Wed, 19 Feb 2014 14:12:37 +0000 From: Adam Thompson To: Karl Dahlke Message-ID: <20140219141237.GK28870@toaster.adamthompson.me.uk> References: <20140119042137.eklhad@comcast.net> <20140219113807.GJ28870@toaster.adamthompson.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140219113807.GJ28870@toaster.adamthompson.me.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] segfault with small pool X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 14:13:36 -0000 On Wed, Feb 19, 2014 at 11:38:07AM +0000, Adam Thompson wrote: > On Wed, Feb 19, 2014 at 04:21:37AM -0500, Karl Dahlke wrote: > > While doing this, I was looking at my edbrowse wiki article, > > putting in more feature content as Adam suggested, > > and I was verifying some of the internal wiki links, > > and got a segfault. > Oops, should have debugged fully first. > Looks like it's the currently being addressed lack of error checking in > jsloc.cpp which is to blame here. > This is currently being fixed. Ok, fixed (and pushed fixes for) much of this, as well as fixing freeJavaContext so it correctly handles compartments (where correct = not failing asserts in my debug build of mozjs 24). I'm now seeing a segfault in encodeTags relating to a stringAndChar call. I'm having a go at debugging this, but it's a realloc segfault so I think I'll have to look at it in valgrind to work out why it's exploding. Cheers, Adam.