From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] JSCLASS_GLOBAL_FLAGS another assert
Date: Fri, 25 Apr 2014 15:48:21 +0000 [thread overview]
Message-ID: <20140325154821.eklhad@comcast.net> (raw)
Ok folks, I need your thoughts here.
I ran into another assert when the bank of america website tried
to create a new window.
It was the same problem as the url class.
It tried to make the new object but the class has JSCLASS_GLOBAL_FLAGS set
and I guess that's a bad thing cause it asserts,
at leasst on the debug environment.
just call window.open() and see.
So, I take the flag JSCLASS_GLOBAL_FLAGS out of the window class spec and
now it asserts at
state->jwin = JS_NewGlobalObject(state->jcx, &window_class, NULL);
The global object has to have the global flag set,
but it is part of a class that could be instantiated to make other windows,
wherein the global flag should not be set.
I guess that's what is happening???
Should I make two different classes, Window and GlobalWindow?
Not sure what to do here.
Karl Dahlke
next reply other threads:[~2014-04-25 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 15:48 Karl Dahlke [this message]
2014-04-25 22:34 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325154821.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).