From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x22a.google.com (mail-we0-x22a.google.com [IPv6:2a00:1450:400c:c03::22a]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 0BE6878AD1 for ; Wed, 6 Aug 2014 11:06:32 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id w62so3060526wes.15 for ; Wed, 06 Aug 2014 11:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-transfer-encoding; bh=y87RqF4+86ixSsov7lnUiTpmWM9aHpGYJvd1VC5GgU8=; b=MXuWVwhkGFcxmQfNcZ2mGjWXbaxilmnqB/KpNlJvueBEDWU04YGPSkRyPWQK9pf2i2 4NiW0yx2jZj3Vdtnl2EYZrD1IyYbUEp+hQm4UihcF67EGVuhKXFuEdsUx9hY0Fx4AWSp C+w4bDLYt3Ku2yeS4sXZmBOakhTveSvsoYtpR5w+RsvTrZ7t0JdfRjDjWwFDG6jpin7Z IbN+M03xX59TyrYikLlspgIS+5tOJniQh2lehTXGAoYPXWyghE2eFWqfug5jNRs4exFd lIP8rHWDdtP0pJArFbmP70lchtIS44bIQ9uHxv0PCIX9NMKzu8+tlZgULJqmLTCaHhvS Auwg== X-Received: by 10.194.7.167 with SMTP id k7mr17585880wja.11.1407348342194; Wed, 06 Aug 2014 11:05:42 -0700 (PDT) Received: from sigil.Belkin ([109.231.16.247]) by mx.google.com with ESMTPSA id sa4sm4031896wjb.45.2014.08.06.11.05.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Aug 2014 11:05:41 -0700 (PDT) Date: Wed, 6 Aug 2014 20:05:39 +0200 From: Paul Onyschuk To: Edbrowse-dev@lists.the-brannons.com Message-Id: <20140806200539.4a2628fe870f9209014866c5@gmail.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.23; x86_64-alpine-linux-musl) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Edbrowse-dev] Using C99? X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2014 18:06:34 -0000 Is edbrowse targeting C89 or there is a reason why some of the newer features aren't used? That could be the case very well, if a compilation under Visual Studio is supported, since Microsoft decided not to update C beyond C89. I'm asking, because there are places, where code could be improved a little bit. Some examples: - designated initializer for arrays in message.c - bool type from instead of eb_bool (this is cosmetic) - snprintf() for string manipulation with bound checking, could be used to replace strcpy()/strcat() where performance isn't important - strdup() instead of cloneString(), asprintf() instead of appendString () and prependString(). Those aren't standard functions, but enviroment with C99 compiler should provide them. But then according to readme, edbrowse is moving toward C++, so maybe it isn't worth the hustle. -- Paul Onyschuk